From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lai Jiangshan Subject: Re: [PATCH] xl: suppress suspend/resume functions on platforms which do not support it. Date: Fri, 14 Feb 2014 13:42:52 +0800 Message-ID: <52FDACDC.2010607@cn.fujitsu.com> References: <1392215257-26993-1-git-send-email-ian.campbell@citrix.com> <1392215531.13563.79.camel@kazak.uk.xensource.com> <21243.35619.819765.162321@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21243.35619.819765.162321@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org, Ian Campbell , george.dunlap@citrix.com List-Id: xen-devel@lists.xenproject.org On 02/12/2014 10:54 PM, Ian Jackson wrote: > Ian Campbell writes ("Re: [PATCH] xl: suppress suspend/resume functions on platforms which do not support it."): >> On Wed, 2014-02-12 at 14:27 +0000, Ian Campbell wrote: >>> ARM does not (currently) support migration, so stop offering tasty looking >>> treats like "xl migrate". > >>> Other than the additions of the #define/#ifdef there is a tiny bit of code >>> motion ("dump-core" in the command list and core_dump_domain in the >>> implementations) which serves to put ifdeffable bits next to each other. > > I'm not a huge fan of #ifdef but this is tolerable, I think. > > Acked-by: Ian Jackson Also Acked-by: Lai Jiangshan Thanks, Lai > > I think this should go into 4.4. It is essential that we start > advertising lack-of-resume in 4.4 as otherwise in 4.5 we'll have to > invent a new HAVE_HAVE_NO_SUSPEND_RESUME which tells you whether the > lack of HAVE_NO_SUSPEND_RESUME means that you can definitely > suspend/resume. > > Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel >