From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH-4.5 v2 07/10] xen/arm: don't protect GICH and lr_queue accesses with gic.lock Date: Fri, 14 Feb 2014 17:37:41 +0000 Message-ID: <52FE5465.8060803@linaro.org> References: <1392393098-7351-7-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1392393098-7351-7-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: julien.grall@citrix.com, xen-devel@lists.xensource.com, Ian.Campbell@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Stefano, On 02/14/2014 03:51 PM, Stefano Stabellini wrote: > GICH is banked, protect accesses by disabling interrupts. > Protect lr_queue accesses with the vgic.lock only. > gic.lock only protects accesses to GICD now. > > Signed-off-by: Stefano Stabellini > --- > xen/arch/arm/gic.c | 22 +++------------------- > xen/arch/arm/vgic.c | 12 ++++++++++-- > 2 files changed, 13 insertions(+), 21 deletions(-) > > diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c > index 0955d48..6386ccb 100644 > --- a/xen/arch/arm/gic.c > +++ b/xen/arch/arm/gic.c > @@ -667,19 +667,14 @@ void gic_remove_from_queues(struct vcpu *v, unsigned int virtual_irq) > { > struct pending_irq *p = irq_to_pending(v, virtual_irq); > > - spin_lock(&gic.lock); > if ( !list_empty(&p->lr_queue) ) > list_del_init(&p->lr_queue); > - spin_unlock(&gic.lock); > } This patch doesn't apply correctly on the latest master. The commit 0ddaeff has replace spin_lock by spin_lock_irqsave. You need to rebase your patches series at least on top of this patch. Regards, -- Julien Grall