From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: route irqs to cpu0 Date: Wed, 19 Feb 2014 13:43:29 +0000 Message-ID: <5304B501.2010207@linaro.org> References: <1390844023-23123-1-git-send-email-oleksandr.tyshchenko@globallogic.com> <52E69CBC.3090207@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: Oleksandr Tyshchenko , George Dunlap , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi all, Ping? It would be nice to have this patch for Xen 4.4 as IPI priority patch won't be pushed before the release. The patch is a minor change and won't impact normal use. When dom0 is built, Xen always do it on CPU 0. Regards, On 02/04/2014 04:20 PM, Stefano Stabellini wrote: > gic_route_irq_to_guest routes all IRQs to > cpumask_of(smp_processor_id()), but actually it always called on cpu0. > To avoid confusion and possible issues in case someone modified the code > and reassigned a particular irq to a cpu other than cpu0, hardcode > cpumask_of(0). > > Signed-off-by: Stefano Stabellini > > diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c > index e6257a7..8854800 100644 > --- a/xen/arch/arm/gic.c > +++ b/xen/arch/arm/gic.c > @@ -776,8 +776,8 @@ int gic_route_irq_to_guest(struct domain *d, const struct dt_irq *irq, > > level = dt_irq_is_level_triggered(irq); > > - gic_set_irq_properties(irq->irq, level, cpumask_of(smp_processor_id()), > - 0xa0); > + /* TODO: handle routing irqs to cpus != cpu0 */ > + gic_set_irq_properties(irq->irq, level, cpumask_of(0), 0xa0); > > retval = __setup_irq(desc, irq->irq, action); > if (retval) { > -- Julien Grall