From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5 7/8] xen/irq: Handle multiple action per IRQ Date: Wed, 19 Feb 2014 14:41:48 +0000 Message-ID: <5304C2AC.5080800@linaro.org> References: <1390581822-32624-1-git-send-email-julien.grall@linaro.org> <1390581822-32624-8-git-send-email-julien.grall@linaro.org> <1392810905.29739.19.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WG8LR-0005OD-Oc for xen-devel@lists.xenproject.org; Wed, 19 Feb 2014 14:41:54 +0000 Received: by mail-ea0-f180.google.com with SMTP id o10so410895eaj.11 for ; Wed, 19 Feb 2014 06:41:51 -0800 (PST) In-Reply-To: <1392810905.29739.19.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, Keir Fraser , stefano.stabellini@citrix.com, patches@linaro.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 02/19/2014 11:55 AM, Ian Campbell wrote: > On Fri, 2014-01-24 at 16:43 +0000, Julien Grall wrote: >> On ARM, it may happen (eg ARM SMMU) to setup multiple handler for the same >> interrupt. > > Mention here that you are therefore creating a linked list of actions > for each interrupt. > > If you use xen/list.h for this then you get a load of helpers and > iterators which would save you open coding them. I will use it on the next version. > Some discussion of the behaviour wrt acking the physical interrupt might > also be interesting, especially in the case where the shared IRQ is > routed to the guest and to the hypervisor or to multiple guests. For now, it's forbidden by the patch #3 of this series. Sharing IRQ between Xen and guest will need a bit of rework, mainly when the Stefano's patch series to remove the maintenance interrupt will be applied. Cheers, -- Julien Grall