From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH for-4.5] xen/serial: Don't leak memory
 mapping if the serial initialization has failed
Date: Wed, 19 Feb 2014 17:46:50 +0000
Message-ID: <5304EE0A.60605@linaro.org>
References: <1392154050-21649-1-git-send-email-julien.grall@linaro.org>
	<1392812466.29739.33.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WGBEU-0005WQ-Ph
	for xen-devel@lists.xenproject.org; Wed, 19 Feb 2014 17:46:54 +0000
Received: by mail-ee0-f53.google.com with SMTP id t10so392029eei.12
	for <xen-devel@lists.xenproject.org>;
	Wed, 19 Feb 2014 09:46:53 -0800 (PST)
In-Reply-To: <1392812466.29739.33.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 02/19/2014 12:21 PM, Ian Campbell wrote:
> On Tue, 2014-02-11 at 21:27 +0000, Julien Grall wrote:
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Although you could also consider moving the dt_device_get_irq before the
> ioremap_attr in most cases.

I will use this solution.

Cheers,

-- 
Julien Grall