From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 6/6] xen/arm: Replace early_printk call to printk call Date: Thu, 20 Feb 2014 11:01:36 +0000 Message-ID: <5305E090.4030602@linaro.org> References: <1388957191-10337-1-git-send-email-julien.grall@linaro.org> <1388957191-10337-7-git-send-email-julien.grall@linaro.org> <1392808847.23084.138.camel@kazak.uk.xensource.com> <5304F058.6090503@linaro.org> <1392887074.22494.7.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WGRNs-0000BF-C8 for xen-devel@lists.xenproject.org; Thu, 20 Feb 2014 11:01:40 +0000 Received: by mail-we0-f176.google.com with SMTP id q58so1305826wes.21 for ; Thu, 20 Feb 2014 03:01:38 -0800 (PST) In-Reply-To: <1392887074.22494.7.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com, tim@xen.org, patches@linaro.org List-Id: xen-devel@lists.xenproject.org On 20/02/14 09:04, Ian Campbell wrote: > On Wed, 2014-02-19 at 17:56 +0000, Julien Grall wrote: >> Hi Ian, >> >> On 02/19/2014 11:20 AM, Ian Campbell wrote: >>> On Sun, 2014-01-05 at 21:26 +0000, Julien Grall wrote: >>>> Now that the console supports earlyprintk, we can get a rid of >>>> early_printk call. >>>> >>>> Signed-off-by: Julien Grall >>> >>> Acked-by: Ian Campbell >> >> Thanks, due to some conflicts I have rebased this patch on top my patch >> "xen/serial: Don't leak memory mapping if the serial initialization has >> failed". >> >> I will resend this series later. > > Thanks. > >>> Now all we need is a way to make it a runtime option :-) >> >> I let you write a device tree parser in assembly ;). > > ;-) > > I was actually thinking more along the lines of a .word at a defined > offset which you could hex edit to a specific value to activate a > particular flavour of early printk handling. That would be sufficient > e.g. for osstest to activate the appropriate stuff for the specific > platform. I don't see useful use case to have a such early printk implementation in Xen. When the board is fully supported, failed at early stage (e.g before console is initialized) is very unlikely. At least if you don't play with memory. I see osstest like a more generic test suite. If it fails at early stage, the developper should give a try himself (most of the time early printk is not useful to find the really bug), that would mean it need to recompile Xen. Cheers, -- Julien Grall