From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
stefano.stabellini@citrix.com
Subject: Re: [RFC for-4.5 4/5] xen/arm: Remove processor specific setup in vcpu_initialise
Date: Thu, 20 Feb 2014 16:45:34 +0000 [thread overview]
Message-ID: <5306312E.5000009@linaro.org> (raw)
In-Reply-To: <1392812318.29739.31.camel@kazak.uk.xensource.com>
Hi Ian,
On 02/19/2014 12:18 PM, Ian Campbell wrote:
> On Tue, 2014-02-11 at 20:04 +0000, Julien Grall wrote:
>> diff --git a/xen/arch/arm/arm32/proc-v7-c.c b/xen/arch/arm/arm32/proc-v7-c.c
>> new file mode 100644
>> index 0000000..a3b94a2
>> --- /dev/null
>> +++ b/xen/arch/arm/arm32/proc-v7-c.c
>> @@ -0,0 +1,32 @@
>> +/*
>> + * xen/arch/arm/arm32/proc-v7-c.c
>> + *
>> + * arm v7 specific initializations (C part)
>
> I think strictly speaking this is actually cortex a{7,15} specific.
> Calling this file "proc-v7-ca15.c" or something (core-cortex.c?) would
> be nicer than the ugly -c suffix...
Right, but it's possible to have some specific quirk written in C for
other ARMv7 CPU.
I think we need to have a file where we can store v7 code (as
proc-v7.S). Creating a file per specific processor for only one function
seems odd. I'm open to any other generic name for this file.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2014-02-20 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 20:04 [RFC for-4.5 0/5] xen/arm: Remove processor specific bits in code Julien Grall
2014-02-11 20:04 ` [RFC for-4.5 1/5] xen/arm32: head.S: Remove CA15 and CA7 specific includes Julien Grall
2014-02-19 12:05 ` Ian Campbell
2014-02-11 20:04 ` [RFC for-4.5 2/5] xen/arm32: Introduce lookup_processor_type Julien Grall
2014-02-19 12:10 ` Ian Campbell
2014-02-11 20:04 ` [RFC for-4.5 3/5] xen/arm64: Implement lookup_processor_type as a dummy function Julien Grall
2014-02-19 12:11 ` Ian Campbell
2014-02-11 20:04 ` [RFC for-4.5 4/5] xen/arm: Remove processor specific setup in vcpu_initialise Julien Grall
2014-02-19 12:18 ` Ian Campbell
2014-02-20 16:45 ` Julien Grall [this message]
2014-02-20 19:43 ` Julien Grall
2014-02-24 9:58 ` Ian Campbell
2014-02-11 20:04 ` [RFC for-4.5 5/5] xen/arm: Remove asm-arm/processor-ca{15, 7}.h headers Julien Grall
2014-02-19 12:19 ` Ian Campbell
2014-02-20 16:49 ` Julien Grall
2014-02-20 16:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5306312E.5000009@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).