From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5 7/8] xen/irq: Handle multiple action per IRQ Date: Thu, 20 Feb 2014 21:29:33 +0000 Message-ID: <530673BD.9010301@linaro.org> References: <1390581822-32624-1-git-send-email-julien.grall@linaro.org> <1390581822-32624-8-git-send-email-julien.grall@linaro.org> <1392810905.29739.19.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WGbBZ-0008Bs-Or for xen-devel@lists.xenproject.org; Thu, 20 Feb 2014 21:29:37 +0000 Received: by mail-ea0-f182.google.com with SMTP id r15so1171979ead.41 for ; Thu, 20 Feb 2014 13:29:35 -0800 (PST) In-Reply-To: <1392810905.29739.19.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, Keir Fraser , stefano.stabellini@citrix.com, patches@linaro.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 02/19/2014 11:55 AM, Ian Campbell wrote: > On Fri, 2014-01-24 at 16:43 +0000, Julien Grall wrote: >> On ARM, it may happen (eg ARM SMMU) to setup multiple handler for the same >> interrupt. > > Mention here that you are therefore creating a linked list of actions > for each interrupt. > > If you use xen/list.h for this then you get a load of helpers and > iterators which would save you open coding them. After thinking, using xen/list.h won't really remove open code, except removing "action_ptr" in release_dt_irq. Calling release_dt_irq to an IRQ with multiple action shouldn't be called often. Therefore, having both prev and next is a waste of space. Cheers, -- Julien Grall