From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5 7/8] xen/irq: Handle multiple action per IRQ Date: Mon, 24 Feb 2014 14:08:53 +0000 Message-ID: <530B5275.7010008@citrix.com> References: <1390581822-32624-1-git-send-email-julien.grall@linaro.org> <1390581822-32624-8-git-send-email-julien.grall@linaro.org> <1392810905.29739.19.camel@kazak.uk.xensource.com> <530673BD.9010301@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WHwDK-0001yj-1O for xen-devel@lists.xenproject.org; Mon, 24 Feb 2014 14:08:58 +0000 In-Reply-To: <530673BD.9010301@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Keir Fraser , Ian Campbell , patches@linaro.org, tim@xen.org, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org (Adding Jan for x86 part). On 02/20/2014 09:29 PM, Julien Grall wrote: > Hi Ian, > > On 02/19/2014 11:55 AM, Ian Campbell wrote: >> On Fri, 2014-01-24 at 16:43 +0000, Julien Grall wrote: >>> On ARM, it may happen (eg ARM SMMU) to setup multiple handler for the same >>> interrupt. >> >> Mention here that you are therefore creating a linked list of actions >> for each interrupt. >> >> If you use xen/list.h for this then you get a load of helpers and >> iterators which would save you open coding them. > > After thinking, using xen/list.h won't really remove open code, except > removing "action_ptr" in release_dt_irq. > > Calling release_dt_irq to an IRQ with multiple action shouldn't be > called often. Therefore, having both prev and next is a waste of space. Jan, as it's common code, do you have any thoughts? -- Julien Grall