From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] libxl: arm: do not create /chosen/bootargs in DTB if no cmdline is specified Date: Thu, 27 Feb 2014 14:39:47 +0000 Message-ID: <530F4E33.1060403@eu.citrix.com> References: <1393416780-10912-1-git-send-email-ian.campbell@citrix.com> <1393416841.18730.38.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1393416841.18730.38.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: ian.jackson@eu.citrix.com, julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 02/26/2014 12:14 PM, Ian Campbell wrote: > On Wed, 2014-02-26 at 12:13 +0000, Ian Campbell wrote: >> Otherwise we deference a NULL pointer. >> >> I saw this while experimenting with libvirt on Xen on ARM, xl already checks >> that the command line is non NULL and provides "" as a default. >> >> Signed-off-by: Ian Campbell >> Cc: george.dunlap@citrix.com> > Typo (extra ">") so Goerge's CC got missed out... I'm not aware (yet) of anything that might make us delay the release. -George