From: Keir Fraser <keir.xen@gmail.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/AMD: re-use function wide variables in init_amd()
Date: Fri, 28 Feb 2014 16:54:40 +0000 [thread overview]
Message-ID: <5310BF50.3050707@gmail.com> (raw)
In-Reply-To: <5310CBFF0200007800120491@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 643 bytes --]
Jan Beulich wrote:
>
> Signed-off-by: Jan Beulich<jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
>
>
> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -399,13 +399,9 @@ static void __devinit init_amd(struct cp
> * revision D (model = 0x14) and later actually support it.
> * (AMD Erratum #110, docId: 25759).
> */
> - unsigned int lo, hi;
> -
> clear_bit(X86_FEATURE_LAHF_LM, c->x86_capability);
> - if (!rdmsr_amd_safe(0xc001100d,&lo,&hi)) {
> - hi&= ~1;
> - wrmsr_amd_safe(0xc001100d, lo, hi);
> - }
> + if (!rdmsr_amd_safe(0xc001100d,&l,&h))
> + wrmsr_amd_safe(0xc001100d, l, h& ~1);
> }
>
> switch(c->x86)
>
>
[-- Attachment #1.2: Type: text/html, Size: 998 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2014-02-28 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 16:48 [PATCH] x86/AMD: re-use function wide variables in init_amd() Jan Beulich
2014-02-28 16:54 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310BF50.3050707@gmail.com \
--to=keir.xen@gmail.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).