From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] x86/ACPI: also print address space for PM1x fields Date: Fri, 28 Feb 2014 16:55:43 +0000 Message-ID: <5310BF8F.6080706@gmail.com> References: <5310CC730200007800120495@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4278944338052735500==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WJQiy-0005Qk-QY for xen-devel@lists.xenproject.org; Fri, 28 Feb 2014 16:55:49 +0000 Received: by mail-we0-f177.google.com with SMTP id t61so747808wes.8 for ; Fri, 28 Feb 2014 08:55:47 -0800 (PST) In-Reply-To: <5310CC730200007800120495@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============4278944338052735500== Content-Type: multipart/alternative; boundary="------------090205090405090500090206" This is a multi-part message in MIME format. --------------090205090405090500090206 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Jan Beulich wrote: > > At least one vendor is in the process of making systems available where > these live in MMIO, not in I/O port space. > > Signed-off-by: Jan Beulich Probably an abundance of caution to keep everything platform related in sync between dom0 and Xen. I agree this shouldn't be necessary in this case and I'm okay with this simplification. Frankly I doubt anyone has to specify this option on any halfway sane box anyway. Acked-by: Keir Fraser > > --- a/xen/arch/x86/acpi/boot.c > +++ b/xen/arch/x86/acpi/boot.c > @@ -402,11 +402,15 @@ acpi_fadt_parse_sleep_info(struct acpi_t > acpi_fadt_copy_address(pm1b_evt, pm1b_event, pm1_event); > > printk(KERN_INFO PREFIX > - "SLEEP INFO: pm1x_cnt[%"PRIx64",%"PRIx64"], " > - "pm1x_evt[%"PRIx64",%"PRIx64"]\n", > + "SLEEP INFO: pm1x_cnt[%d:%"PRIx64",%d:%"PRIx64"], " > + "pm1x_evt[%d:%"PRIx64",%d:%"PRIx64"]\n", > + acpi_sinfo.pm1a_cnt_blk.space_id, > acpi_sinfo.pm1a_cnt_blk.address, > + acpi_sinfo.pm1b_cnt_blk.space_id, > acpi_sinfo.pm1b_cnt_blk.address, > + acpi_sinfo.pm1a_evt_blk.space_id, > acpi_sinfo.pm1a_evt_blk.address, > + acpi_sinfo.pm1b_evt_blk.space_id, > acpi_sinfo.pm1b_evt_blk.address); > > /* Now FACS... */ > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------090205090405090500090206 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Jan Beulich wrote:

At least one vendor is in the process of making systems available where
these live in MMIO, not in I/O port space.

Signed-off-by: Jan Beulich<jbeulich@suse.com>

Probably an abundance of caution to keep everything platform related in sync between dom0 and Xen. I agree this shouldn't be necessary in this case and I'm okay with this simplification. Frankly I doubt anyone has to specify this option on any halfway sane box anyway.

Acked-by: Keir Fraser <keir@xen.org>

--- a/xen/arch/x86/acpi/boot.c
+++ b/xen/arch/x86/acpi/boot.c
@@ -402,11 +402,15 @@ acpi_fadt_parse_sleep_info(struct acpi_t
acpi_fadt_copy_address(pm1b_evt, pm1b_event, pm1_event);

printk(KERN_INFO PREFIX
-        "SLEEP INFO: pm1x_cnt[%"PRIx64",%"PRIx64"], "
-        "pm1x_evt[%"PRIx64",%"PRIx64"]\n",
+        "SLEEP INFO: pm1x_cnt[%d:%"PRIx64",%d:%"PRIx64"], "
+        "pm1x_evt[%d:%"PRIx64",%d:%"PRIx64"]\n",
+        acpi_sinfo.pm1a_cnt_blk.space_id,
       acpi_sinfo.pm1a_cnt_blk.address,
+        acpi_sinfo.pm1b_cnt_blk.space_id,
       acpi_sinfo.pm1b_cnt_blk.address,
+        acpi_sinfo.pm1a_evt_blk.space_id,
       acpi_sinfo.pm1a_evt_blk.address,
+        acpi_sinfo.pm1b_evt_blk.space_id,
       acpi_sinfo.pm1b_evt_blk.address);

/* Now FACS... */

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel --------------090205090405090500090206-- --===============4278944338052735500== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4278944338052735500==--