* [PATCH] x86/ACPI: also print address space for PM1x fields
@ 2014-02-28 16:50 Jan Beulich
2014-02-28 16:55 ` Keir Fraser
2014-02-28 16:55 ` Keir Fraser
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2014-02-28 16:50 UTC (permalink / raw)
To: xen-devel
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
At least one vendor is in the process of making systems available where
these live in MMIO, not in I/O port space.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/acpi/boot.c
+++ b/xen/arch/x86/acpi/boot.c
@@ -402,11 +402,15 @@ acpi_fadt_parse_sleep_info(struct acpi_t
acpi_fadt_copy_address(pm1b_evt, pm1b_event, pm1_event);
printk(KERN_INFO PREFIX
- "SLEEP INFO: pm1x_cnt[%"PRIx64",%"PRIx64"], "
- "pm1x_evt[%"PRIx64",%"PRIx64"]\n",
+ "SLEEP INFO: pm1x_cnt[%d:%"PRIx64",%d:%"PRIx64"], "
+ "pm1x_evt[%d:%"PRIx64",%d:%"PRIx64"]\n",
+ acpi_sinfo.pm1a_cnt_blk.space_id,
acpi_sinfo.pm1a_cnt_blk.address,
+ acpi_sinfo.pm1b_cnt_blk.space_id,
acpi_sinfo.pm1b_cnt_blk.address,
+ acpi_sinfo.pm1a_evt_blk.space_id,
acpi_sinfo.pm1a_evt_blk.address,
+ acpi_sinfo.pm1b_evt_blk.space_id,
acpi_sinfo.pm1b_evt_blk.address);
/* Now FACS... */
[-- Attachment #2: x86-ACPI-pm1x-space.patch --]
[-- Type: text/plain, Size: 1028 bytes --]
x86/ACPI: also print address space for PM1x fields
At least one vendor is in the process of making systems available where
these live in MMIO, not in I/O port space.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/acpi/boot.c
+++ b/xen/arch/x86/acpi/boot.c
@@ -402,11 +402,15 @@ acpi_fadt_parse_sleep_info(struct acpi_t
acpi_fadt_copy_address(pm1b_evt, pm1b_event, pm1_event);
printk(KERN_INFO PREFIX
- "SLEEP INFO: pm1x_cnt[%"PRIx64",%"PRIx64"], "
- "pm1x_evt[%"PRIx64",%"PRIx64"]\n",
+ "SLEEP INFO: pm1x_cnt[%d:%"PRIx64",%d:%"PRIx64"], "
+ "pm1x_evt[%d:%"PRIx64",%d:%"PRIx64"]\n",
+ acpi_sinfo.pm1a_cnt_blk.space_id,
acpi_sinfo.pm1a_cnt_blk.address,
+ acpi_sinfo.pm1b_cnt_blk.space_id,
acpi_sinfo.pm1b_cnt_blk.address,
+ acpi_sinfo.pm1a_evt_blk.space_id,
acpi_sinfo.pm1a_evt_blk.address,
+ acpi_sinfo.pm1b_evt_blk.space_id,
acpi_sinfo.pm1b_evt_blk.address);
/* Now FACS... */
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/ACPI: also print address space for PM1x fields
2014-02-28 16:50 [PATCH] x86/ACPI: also print address space for PM1x fields Jan Beulich
@ 2014-02-28 16:55 ` Keir Fraser
2014-02-28 16:55 ` Keir Fraser
1 sibling, 0 replies; 3+ messages in thread
From: Keir Fraser @ 2014-02-28 16:55 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 1095 bytes --]
Jan Beulich wrote:
>
> At least one vendor is in the process of making systems available where
> these live in MMIO, not in I/O port space.
>
> Signed-off-by: Jan Beulich<jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
>
> --- a/xen/arch/x86/acpi/boot.c
> +++ b/xen/arch/x86/acpi/boot.c
> @@ -402,11 +402,15 @@ acpi_fadt_parse_sleep_info(struct acpi_t
> acpi_fadt_copy_address(pm1b_evt, pm1b_event, pm1_event);
>
> printk(KERN_INFO PREFIX
> - "SLEEP INFO: pm1x_cnt[%"PRIx64",%"PRIx64"], "
> - "pm1x_evt[%"PRIx64",%"PRIx64"]\n",
> + "SLEEP INFO: pm1x_cnt[%d:%"PRIx64",%d:%"PRIx64"], "
> + "pm1x_evt[%d:%"PRIx64",%d:%"PRIx64"]\n",
> + acpi_sinfo.pm1a_cnt_blk.space_id,
> acpi_sinfo.pm1a_cnt_blk.address,
> + acpi_sinfo.pm1b_cnt_blk.space_id,
> acpi_sinfo.pm1b_cnt_blk.address,
> + acpi_sinfo.pm1a_evt_blk.space_id,
> acpi_sinfo.pm1a_evt_blk.address,
> + acpi_sinfo.pm1b_evt_blk.space_id,
> acpi_sinfo.pm1b_evt_blk.address);
>
> /* Now FACS... */
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 1864 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/ACPI: also print address space for PM1x fields
2014-02-28 16:50 [PATCH] x86/ACPI: also print address space for PM1x fields Jan Beulich
2014-02-28 16:55 ` Keir Fraser
@ 2014-02-28 16:55 ` Keir Fraser
1 sibling, 0 replies; 3+ messages in thread
From: Keir Fraser @ 2014-02-28 16:55 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 1368 bytes --]
Jan Beulich wrote:
>
> At least one vendor is in the process of making systems available where
> these live in MMIO, not in I/O port space.
>
> Signed-off-by: Jan Beulich<jbeulich@suse.com>
Probably an abundance of caution to keep everything platform related in
sync between dom0 and Xen. I agree this shouldn't be necessary in this
case and I'm okay with this simplification. Frankly I doubt anyone has
to specify this option on any halfway sane box anyway.
Acked-by: Keir Fraser <keir@xen.org>
>
> --- a/xen/arch/x86/acpi/boot.c
> +++ b/xen/arch/x86/acpi/boot.c
> @@ -402,11 +402,15 @@ acpi_fadt_parse_sleep_info(struct acpi_t
> acpi_fadt_copy_address(pm1b_evt, pm1b_event, pm1_event);
>
> printk(KERN_INFO PREFIX
> - "SLEEP INFO: pm1x_cnt[%"PRIx64",%"PRIx64"], "
> - "pm1x_evt[%"PRIx64",%"PRIx64"]\n",
> + "SLEEP INFO: pm1x_cnt[%d:%"PRIx64",%d:%"PRIx64"], "
> + "pm1x_evt[%d:%"PRIx64",%d:%"PRIx64"]\n",
> + acpi_sinfo.pm1a_cnt_blk.space_id,
> acpi_sinfo.pm1a_cnt_blk.address,
> + acpi_sinfo.pm1b_cnt_blk.space_id,
> acpi_sinfo.pm1b_cnt_blk.address,
> + acpi_sinfo.pm1a_evt_blk.space_id,
> acpi_sinfo.pm1a_evt_blk.address,
> + acpi_sinfo.pm1b_evt_blk.space_id,
> acpi_sinfo.pm1b_evt_blk.address);
>
> /* Now FACS... */
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 2142 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-28 16:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-28 16:50 [PATCH] x86/ACPI: also print address space for PM1x fields Jan Beulich
2014-02-28 16:55 ` Keir Fraser
2014-02-28 16:55 ` Keir Fraser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).