From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86: don't propagate acpi_skip_timer_override do Dom0
Date: Fri, 28 Feb 2014 17:38:49 +0000 [thread overview]
Message-ID: <5310C9A9.8080000@citrix.com> (raw)
In-Reply-To: <5310CB88020000780012046C@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 2443 bytes --]
On 28/02/14 16:46, Jan Beulich wrote:
> It's unclear why c/s 4850:923dd9975981 added this - Dom0 isn't
> controlling the timer interrupt, and hence has no need to know.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/acpi/boot.c
> +++ b/xen/arch/x86/acpi/boot.c
> @@ -56,7 +56,9 @@ bool_t __initdata acpi_ht = 1; /* enable
> bool_t __initdata acpi_lapic;
> bool_t __initdata acpi_ioapic;
>
> -bool_t acpi_skip_timer_override __initdata;
> +/* acpi_skip_timer_override: Skip IRQ0 overrides. */
> +static bool_t acpi_skip_timer_override __initdata;
> +boolean_param("acpi_skip_timer_override", acpi_skip_timer_override);
>
> #ifdef CONFIG_X86_LOCAL_APIC
> static u64 acpi_lapic_addr __initdata = APIC_DEFAULT_PHYS_BASE;
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -71,10 +71,6 @@ static void parse_acpi_param(char *s);
> custom_param("acpi", parse_acpi_param);
>
> /* **** Linux config option: propagated to domain0. */
> -/* acpi_skip_timer_override: Skip IRQ0 overrides. */
> -boolean_param("acpi_skip_timer_override", acpi_skip_timer_override);
> -
> -/* **** Linux config option: propagated to domain0. */
> /* noapic: Disable IOAPIC setup. */
> boolean_param("noapic", skip_ioapic_setup);
>
> @@ -1365,9 +1361,6 @@ void __init __start_xen(unsigned long mb
> /* Append any extra parameters. */
> if ( skip_ioapic_setup && !strstr(dom0_cmdline, "noapic") )
> safe_strcat(dom0_cmdline, " noapic");
> - if ( acpi_skip_timer_override &&
> - !strstr(dom0_cmdline, "acpi_skip_timer_override") )
> - safe_strcat(dom0_cmdline, " acpi_skip_timer_override");
> if ( (strlen(acpi_param) == 0) && acpi_disabled )
> {
> printk("ACPI is disabled, notifying Domain 0 (acpi=off)\n");
> --- a/xen/include/asm-x86/acpi.h
> +++ b/xen/include/asm-x86/acpi.h
> @@ -80,7 +80,6 @@ int __acpi_release_global_lock(unsigned
>
> extern bool_t acpi_lapic, acpi_ioapic, acpi_noirq;
> extern bool_t acpi_force, acpi_ht, acpi_disabled;
> -extern bool_t acpi_skip_timer_override;
> extern u32 acpi_smi_cmd;
> extern u8 acpi_enable_value, acpi_disable_value;
> void acpi_pic_sci_set_trigger(unsigned int, u16);
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 3289 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2014-02-28 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 16:46 [PATCH] x86: don't propagate acpi_skip_timer_override do Dom0 Jan Beulich
2014-02-28 17:38 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310C9A9.8080000@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).