From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 5/5] [RFC] Traditional console timestamps
 including milliseconds
Date: Sat, 01 Mar 2014 12:06:09 +0800
Message-ID: <53115CB1.7070905@linaro.org>
References: <1393613824-13230-1-git-send-email-andrew.cooper3@citrix.com>
	<1393613824-13230-6-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1393613824-13230-6-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Hello Andrew,

On 01/03/14 02:57, Andrew Cooper wrote:
> diff --git a/xen/include/asm-x86/time.h b/xen/include/asm-x86/time.h
> index 147b39e..2f9dbd1 100644
> --- a/xen/include/asm-x86/time.h
> +++ b/xen/include/asm-x86/time.h
> @@ -49,7 +49,7 @@ int dom0_pit_access(struct ioreq *ioreq);
>   int cpu_frequency_change(u64 freq);
>
>   struct tm;
> -struct tm wallclock_time(void);
> +struct tm wallclock_time(uint64_t *ns);
>


You also need to modify the prototype in asm-arm/time.h. Otherwise it 
will break compilation on ARM.

BTW, as the function is used by common code, can you merge the both 
prototype in xen/time.h?

Regards,

-- 
Julien Grall