From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 5/5] [RFC] Traditional console timestamps including milliseconds
Date: Mon, 3 Mar 2014 10:35:28 +0000 [thread overview]
Message-ID: <53145AF0.1070801@citrix.com> (raw)
In-Reply-To: <53115CB1.7070905@linaro.org>
On 01/03/14 04:06, Julien Grall wrote:
> Hello Andrew,
>
> On 01/03/14 02:57, Andrew Cooper wrote:
>> diff --git a/xen/include/asm-x86/time.h b/xen/include/asm-x86/time.h
>> index 147b39e..2f9dbd1 100644
>> --- a/xen/include/asm-x86/time.h
>> +++ b/xen/include/asm-x86/time.h
>> @@ -49,7 +49,7 @@ int dom0_pit_access(struct ioreq *ioreq);
>> int cpu_frequency_change(u64 freq);
>>
>> struct tm;
>> -struct tm wallclock_time(void);
>> +struct tm wallclock_time(uint64_t *ns);
>>
>
>
> You also need to modify the prototype in asm-arm/time.h. Otherwise it
> will break compilation on ARM.
>
> BTW, as the function is used by common code, can you merge the both
> prototype in xen/time.h?
>
> Regards,
>
Hmm yes - I had overlooked that it was a common function declared in an
x86 header. It certainly should be moved, irrespective of whether this
change actually happens (subject to the RFCs in patch 0)
~Andrew
next prev parent reply other threads:[~2014-03-03 10:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 18:56 [RFC PATCH v2 0/5] Improvements to console timestamps Andrew Cooper
2014-02-28 18:57 ` [PATCH v2 1/5] x86/time: Avoid redundant this_cpu() Andrew Cooper
2014-02-28 18:57 ` [PATCH v2 2/5] x86/time: Always count s_time from Xen boot Andrew Cooper
2014-03-03 10:59 ` David Vrabel
2014-03-06 16:01 ` [PATCH v3] " Tim Deegan
2014-03-06 16:15 ` Jan Beulich
2014-03-06 16:18 ` Andrew Cooper
2014-02-28 18:57 ` [PATCH v2 3/5] x86/time: Initialise time earlier during start_secondary() Andrew Cooper
2014-03-04 9:02 ` Jan Beulich
2014-03-04 10:40 ` Andrew Cooper
2014-02-28 18:57 ` [PATCH v2 4/5] [RFC] xen/console: Provide timestamps as an offset since boot Andrew Cooper
2014-03-03 10:53 ` David Vrabel
2014-02-28 18:57 ` [PATCH v2 5/5] [RFC] Traditional console timestamps including milliseconds Andrew Cooper
2014-03-01 4:06 ` Julien Grall
2014-03-03 10:35 ` Andrew Cooper [this message]
2014-03-04 9:14 ` Jan Beulich
2014-03-04 10:30 ` Andrew Cooper
2014-03-04 20:51 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53145AF0.1070801@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=julien.grall@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).