From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH] Add a "make rpmball" target
Date: Mon, 3 Mar 2014 16:34:20 +0000
Message-ID: <5314AF0C.6080708@eu.citrix.com>
References: <1393858780-11628-1-git-send-email-george.dunlap@eu.citrix.com>
	<20140303162358.GA23543@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20140303162358.GA23543@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 03/03/2014 04:23 PM, Olaf Hering wrote:
> On Mon, Mar 03, George Dunlap wrote:
>
>
>> +%install
>> +rm -rf \$RPM_BUILD_ROOT
>> +mkdir -p \$RPM_BUILD_ROOT
> Newer rpms are supposed to do that automatically, but I dont know what
> "newer" actually means. And certainly it does not hurt to keep this.
>
>> +cd %{_xenroot}
>> +dist/install.sh \$RPM_BUILD_ROOT/
>> +
>> +cd \$RPM_BUILD_ROOT
>> +
>> +# Don't include xen-syms
>> +rm -f boot/xen-syms*
>> +# Remove all the "linked" xen-*.gz files
>> +rm -f \$(find boot/ -type l)
> "find $paht -type l -delete"?

Ack.

>
>> +%files
>> +%defattr(-,root,root,-)
>> +/*
> In this case, to avoid package conflicts, add some tags like:
>
> Obsoletes: xen-libs
> Obsoletes: xen-tools

What exactly would this be for?

> Also "Release: unstable" could be some automatically increasing number,
> like 'date +%s'. This avoids the need for "rpm -Uvh --force xen.rpm".
> Not sure how package managers deal with missing digits in the Release:
> tag. If in doubt, set it to 0.

I'll give this a think.

Thanks for the feedback!

  -George