From: Julien Grall <julien.grall@linaro.org>
To: Konrad Rzeszutek Wilk <konrad@kernel.org>,
jbeulich@suse.com, xen-devel@lists.xenproject.org
Subject: Re: [RFC PATCHv1] serial: Support OXPCIe952 aka Oxford Semiconductor Ltd Device c138 (1415:c138)
Date: Tue, 04 Mar 2014 11:17:37 +0800 [thread overview]
Message-ID: <531545D1.5070409@linaro.org> (raw)
In-Reply-To: <1393898489-30012-1-git-send-email-konrad.wilk@oracle.com>
Hello Konrad,
On 04/03/14 10:01, Konrad Rzeszutek Wilk wrote:
> @@ -917,6 +939,7 @@ void __init ns16550_init(int index, struct ns16550_defaults *defaults)
> uart->io_size = 8;
> uart->reg_width = 1;
> uart->reg_shift = 0;
> + uart->offset = 0;
You also need to set uart->offset = 0 in ns16550_dt_init which is used
by ARM.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-03-04 3:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 2:01 [RFC PATCHv1] serial: Support OXPCIe952 aka Oxford Semiconductor Ltd Device c138 (1415:c138) Konrad Rzeszutek Wilk
2014-03-04 3:17 ` Julien Grall [this message]
2014-03-04 9:43 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2014-03-04 10:36 Konrad Rzeszutek Wilk
2014-03-04 10:57 ` Jan Beulich
2014-03-04 13:29 ` Konrad Rzeszutek Wilk
2014-03-04 15:39 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531545D1.5070409@linaro.org \
--to=julien.grall@linaro.org \
--cc=jbeulich@suse.com \
--cc=konrad@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).