From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC PATCHv1] serial: Support OXPCIe952 aka Oxford
 Semiconductor Ltd Device c138 (1415:c138)
Date: Tue, 04 Mar 2014 11:17:37 +0800
Message-ID: <531545D1.5070409@linaro.org>
References: <1393898489-30012-1-git-send-email-konrad.wilk@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WKfrU-0007n3-La
	for xen-devel@lists.xenproject.org; Tue, 04 Mar 2014 03:17:44 +0000
Received: by mail-pb0-f44.google.com with SMTP id rp16so4601839pbb.31
	for <xen-devel@lists.xenproject.org>;
	Mon, 03 Mar 2014 19:17:41 -0800 (PST)
In-Reply-To: <1393898489-30012-1-git-send-email-konrad.wilk@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad@kernel.org>, jbeulich@suse.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

Hello Konrad,

On 04/03/14 10:01, Konrad Rzeszutek Wilk wrote:
> @@ -917,6 +939,7 @@ void __init ns16550_init(int index, struct ns16550_defaults *defaults)
>       uart->io_size   = 8;
>       uart->reg_width = 1;
>       uart->reg_shift = 0;
> +    uart->offset    = 0;

You also need to set uart->offset = 0 in ns16550_dt_init which is used 
by ARM.

Regards,

-- 
Julien Grall