From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: Ian Campbell <ijc@hellion.org.uk>,
tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build
Date: Wed, 05 Mar 2014 11:39:22 +0800 [thread overview]
Message-ID: <53169C6A.6090700@linaro.org> (raw)
In-Reply-To: <1393981349-6811-1-git-send-email-ian.campbell@citrix.com>
On 05/03/14 09:02, Ian Campbell wrote:
> early printk on ARM is tied to debug being enabled, so error out instead of silently and unexpectedly building without early printk when asked.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/Rules.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index aaa203e..aa2e79f 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -99,4 +99,12 @@ CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_INC=\"debug-$(EARLY_PRINTK_INC).inc\"
> CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD)
> CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS)
> CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT)
> +
> +else # !debug
> +
> +ifneq ($(CONFIG_EARLY_PRINTK),)
> +# Early printk is dependant on a debug build.
> +$(error CONFIG_EARLY_PRINTK enabled for non-debug build)
> +endif
> +
> endif
>
--
Julien Grall
next prev parent reply other threads:[~2014-03-05 3:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 1:02 [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build Ian Campbell
2014-03-05 1:08 ` Ian Campbell
2014-03-05 3:39 ` Julien Grall [this message]
2014-03-13 12:25 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53169C6A.6090700@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=ijc@hellion.org.uk \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).