From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build Date: Wed, 05 Mar 2014 11:39:22 +0800 Message-ID: <53169C6A.6090700@linaro.org> References: <1393981349-6811-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1393981349-6811-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: Ian Campbell , tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 05/03/14 09:02, Ian Campbell wrote: > early printk on ARM is tied to debug being enabled, so error out instead of silently and unexpectedly building without early printk when asked. > > Signed-off-by: Ian Campbell Acked-by: Julien Grall > --- > xen/arch/arm/Rules.mk | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk > index aaa203e..aa2e79f 100644 > --- a/xen/arch/arm/Rules.mk > +++ b/xen/arch/arm/Rules.mk > @@ -99,4 +99,12 @@ CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_INC=\"debug-$(EARLY_PRINTK_INC).inc\" > CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD) > CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS) > CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT) > + > +else # !debug > + > +ifneq ($(CONFIG_EARLY_PRINTK),) > +# Early printk is dependant on a debug build. > +$(error CONFIG_EARLY_PRINTK enabled for non-debug build) > +endif > + > endif > -- Julien Grall