* [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build
@ 2014-03-05 1:02 Ian Campbell
2014-03-05 1:08 ` Ian Campbell
2014-03-05 3:39 ` Julien Grall
0 siblings, 2 replies; 4+ messages in thread
From: Ian Campbell @ 2014-03-05 1:02 UTC (permalink / raw)
To: xen-devel
Cc: Ian Campbell, julien.grall, tim, Ian Campbell, stefano.stabellini
early printk on ARM is tied to debug being enabled, so error out instead of silently and unexpectedly building without early printk when asked.
Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
---
xen/arch/arm/Rules.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
index aaa203e..aa2e79f 100644
--- a/xen/arch/arm/Rules.mk
+++ b/xen/arch/arm/Rules.mk
@@ -99,4 +99,12 @@ CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_INC=\"debug-$(EARLY_PRINTK_INC).inc\"
CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD)
CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS)
CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT)
+
+else # !debug
+
+ifneq ($(CONFIG_EARLY_PRINTK),)
+# Early printk is dependant on a debug build.
+$(error CONFIG_EARLY_PRINTK enabled for non-debug build)
+endif
+
endif
--
1.8.5.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build
2014-03-05 1:02 [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build Ian Campbell
@ 2014-03-05 1:08 ` Ian Campbell
2014-03-05 3:39 ` Julien Grall
1 sibling, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2014-03-05 1:08 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, stefano.stabellini
On Wed, 2014-03-05 at 01:02 +0000, Ian Campbell wrote:
> early printk on ARM is tied to debug being enabled, so error out instead of silently and unexpectedly building without early printk when asked.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Should really be:
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build
2014-03-05 1:02 [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build Ian Campbell
2014-03-05 1:08 ` Ian Campbell
@ 2014-03-05 3:39 ` Julien Grall
2014-03-13 12:25 ` Ian Campbell
1 sibling, 1 reply; 4+ messages in thread
From: Julien Grall @ 2014-03-05 3:39 UTC (permalink / raw)
To: Ian Campbell, xen-devel; +Cc: Ian Campbell, tim, stefano.stabellini
On 05/03/14 09:02, Ian Campbell wrote:
> early printk on ARM is tied to debug being enabled, so error out instead of silently and unexpectedly building without early printk when asked.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/Rules.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index aaa203e..aa2e79f 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -99,4 +99,12 @@ CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_INC=\"debug-$(EARLY_PRINTK_INC).inc\"
> CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD)
> CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS)
> CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT)
> +
> +else # !debug
> +
> +ifneq ($(CONFIG_EARLY_PRINTK),)
> +# Early printk is dependant on a debug build.
> +$(error CONFIG_EARLY_PRINTK enabled for non-debug build)
> +endif
> +
> endif
>
--
Julien Grall
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build
2014-03-05 3:39 ` Julien Grall
@ 2014-03-13 12:25 ` Ian Campbell
0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2014-03-13 12:25 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Wed, 2014-03-05 at 11:39 +0800, Julien Grall wrote:
>
> On 05/03/14 09:02, Ian Campbell wrote:
> > early printk on ARM is tied to debug being enabled, so error out instead of silently and unexpectedly building without early printk when asked.
> >
> > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Acked-by: Julien Grall <julien.grall@linaro.org>
Thanks. Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-13 12:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-05 1:02 [PATCH] xen: arm: prevent building with CONFIG_EARLY_PRINTK if not a debug build Ian Campbell
2014-03-05 1:08 ` Ian Campbell
2014-03-05 3:39 ` Julien Grall
2014-03-13 12:25 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).