From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC 6/6] xen/arm: Replace early_printk call to
	printk call
Date: Wed, 05 Mar 2014 15:53:31 +0800
Message-ID: <5316D7FB.2030602@linaro.org>
References: <1388957191-10337-1-git-send-email-julien.grall@linaro.org>	
	<1388957191-10337-7-git-send-email-julien.grall@linaro.org>
	<1392813207.29739.42.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WL6e4-0004AM-9l
	for xen-devel@lists.xenproject.org; Wed, 05 Mar 2014 07:53:40 +0000
Received: by mail-pa0-f51.google.com with SMTP id kq14so746569pab.24
	for <xen-devel@lists.xenproject.org>;
	Tue, 04 Mar 2014 23:53:35 -0800 (PST)
In-Reply-To: <1392813207.29739.42.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@eu.citrix.com, tim@xen.org, patches@linaro.org
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 19/02/14 20:33, Ian Campbell wrote:
> On Sun, 2014-01-05 at 21:26 +0000, Julien Grall wrote:
>>
>> -/* Some device tree functions may be called both before and after the
>> -   console is initialized. */
>> -#define dt_printk(fmt, ...)                         \
>> -    do                                              \
>> -    {                                               \
>> -        if ( system_state == SYS_STATE_early_boot ) \
>> -            early_printk(fmt, ## __VA_ARGS__);      \
>> -        else                                        \
>> -            printk(fmt, ## __VA_ARGS__);            \
>> -    } while (0)
>> +#define dt_printk(fmt, ...) printk(fmt, ## __VA_ARGS__);
>
> Since dt_printk basically existed solely as a hack to workaround the
> distinction between early_printk and printk I think you could just
> switch everything to printk directly.

I forgot to replace dt_printk by printk in v2. I will send another version.

Sincerely yours,


-- 
Julien Grall