From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH v2 2/2] Add a "make rpmball" target
Date: Wed, 5 Mar 2014 10:10:53 +0000
Message-ID: <5316F82D.702@eu.citrix.com>
References: <1393941409-9105-1-git-send-email-george.dunlap@eu.citrix.com>
	<1393941409-9105-2-git-send-email-george.dunlap@eu.citrix.com>
	<531634E7.3050103@terremark.com> <53163632.3040201@eu.citrix.com>
	<531638F7.9020809@terremark.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <531638F7.9020809@terremark.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Olaf Hering <olaf@aepfle.de>, Ian Campbell <ian.campbell@citrix.com>, M A Young <m.a.young@durham.ac.uk>
List-Id: xen-devel@lists.xenproject.org

On 03/04/2014 08:35 PM, Don Slutz wrote:
> On 03/04/14 15:23, George Dunlap wrote:
>> mkdir -p rpm/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
>
> That does not work, but:
>
>
> mkdir -p rpm/{BUILD,RPMS,SOURCES,SPEC,SRPMS}
>
> does (SPECS is not what you want.)

I'm a bit confused now; your colleague said:

--- Begin Quote ---

s/SPEC/SPECS/ in the above two lines (per the rpm.org site).
It also fixes Don's problem.

--- End Quote ---

Which sounds like the opposite. :-)

The command I sent you was copied from a CentOS wiki -- was the problem 
perhaps that the "cat" command below the mkdir was still using "SPEC" 
instead of "SPECS" (and thus failing there, rather than in the rpmbuild)?

Is your version of rpmbuild happy with just the one directory named 
"SPECS", or would it be better to make all the directories?

I don't have a Centos 5.x system to test it on.

Alternately, we could accept this patch as-is, and then you could post a 
follow-up fixing it on your system.

  -George