From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v1 3/4] serial: Use #defines for PCI vendor and models Date: Wed, 5 Mar 2014 17:34:12 +0000 Message-ID: <53176014.60301@citrix.com> References: <1394040334-16278-1-git-send-email-konrad.wilk@oracle.com> <1394040334-16278-4-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WLFhw-0005pm-ST for xen-devel@lists.xenproject.org; Wed, 05 Mar 2014 17:34:17 +0000 In-Reply-To: <1394040334-16278-4-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org On 05/03/14 17:25, Konrad Rzeszutek Wilk wrote: > Instead of having hard-coded values. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > xen/drivers/char/ns16550.c | 10 +++++++--- > 1 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c > index 06580c8..6fbf358 100644 > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -131,17 +131,21 @@ static struct ns16550_config_quirk __initdata uart_quirk[] = { > .max_bars = 1, /* It can do more, but we would need more custom code.*/ > } > }; > + > +#define PCI_VENDOR_ID_BROADCOM 0x14e4 > +#define PCI_DEVICE_ID_BROADCOM_TRUMANAGE 0x160a > +#define PCI_VENDOR_ID_OXSEMI 0x1415 We probably want a single unified header file containing PCI IDs (certainly vendor). Currently, arch/x86/x86_64/mmconfig.h contains defines for Intel, AMD and Nvidia, and AMD is redefined in defined in arch/x86/oprofile/op_model_athlon.c. ~Andrew > static struct ns16550_config_mmio __initdata uart_config[] = > { > /* Broadcom TruManage device */ > { > - .vendor_id = 0x14e4, > - .dev_id = 0x160a, > + .vendor_id = PCI_VENDOR_ID_BROADCOM, > + .dev_id = PCI_DEVICE_ID_BROADCOM_TRUMANAGE, > .quirk = quirk_trumanage, > }, > /* OXPCIe952 1 Native UART */ > { > - .vendor_id = 0x1415, > + .vendor_id = PCI_VENDOR_ID_OXSEMI, > .dev_id = 0xc138, > .quirk = quirk_oxford, > }