From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3] x86/time: Always count s_time from Xen
	boot
Date: Thu, 6 Mar 2014 16:18:42 +0000
Message-ID: <53189FE2.6050309@citrix.com>
References: <1393613824-13230-1-git-send-email-andrew.cooper3@citrix.com>
	<1393613824-13230-3-git-send-email-andrew.cooper3@citrix.com>
	<20140306160150.GJ11475@deinos.phlegethon.org>
	<5318AD3702000078001219A4@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5318AD3702000078001219A4@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 06/03/14 16:15, Jan Beulich wrote:
>>>> On 06.03.14 at 17:01, Tim Deegan <tim@xen.org> wrote:
>> @@ -203,6 +209,10 @@ GLOBAL(trampoline_end)
>>  __high_start:
>>  #include "x86_64.S"
>>  
>> +        .section .init.data, "a", @progbits
>> +GLOBAL(boot_tsc_stamp)
>> +        .quad   0
> I think it would be better to have that definition in the C file, ...
>
>> --- a/xen/arch/x86/time.c
>> +++ b/xen/arch/x86/time.c
>> @@ -84,6 +84,9 @@ static u16 pit_stamp16;
>>  static u32 pit_stamp32;
>>  static bool_t __read_mostly using_pit;
>>  
>> +/* Boot timestamp, filled in head.S (initdata) */
>> +extern u64 boot_tsc_stamp;
> ... instead of only declaring it here.
>
> Jan
>

Ok - I will see about cleaning this up (as it was my part of the patch)
and respin the full series.