From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC PATCH 3/3] tools, libxl: handle the iomem parameter with the memory_mapping hcall Date: Fri, 07 Mar 2014 12:05:54 +0800 Message-ID: <531945A2.20506@linaro.org> References: <1393721365-22458-1-git-send-email-avanzini.arianna@gmail.com> <1393721365-22458-4-git-send-email-avanzini.arianna@gmail.com> <531308FD.8070007@linaro.org> <1393845546.4058.41.camel@Solace> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1393845546.4058.41.camel@Solace> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: paolo.valente@unimore.it, Ian Campbell , stefano.stabellini@eu.citrix.com, Tim Deegan , Ian Jackson , xen-devel@lists.xen.org, julien.grall@citrix.com, etrudeau@broadcom.com, Jan Beulich , Arianna Avanzini , viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org On 03/03/14 19:19, Dario Faggioli wrote: >> This code is common on both x86 and ARM. On x86, we don't want to map >> the I/O mem region in the guest here. QEMU will do it later. >> > Right. I took a quick look and, as you're saying, I found the call sites > of xc_domain_memory_mapping() in QEMU's code (in _pt_iomem_helper() ). > At the same time, I see QEMU being created as a device model in this > same function, below this hunk... But that does _not_ _always_ happen, I > think, does it? > > In particular, what about PV guests for which libxl__need_xenpv_qemu() > returns 0? Who calls xc_domain_memory_mapping() on the specified iomem > region(s) for them? Only the PV guest knows its memory layout. I guess xc_domain_memory_mapping is called by itself. Adding Tim and Jan that might be able to answer to this question. -- Julien Grall