xl cannot cd-eject an initialy inserted iso in staging-4.2

xl cannot cd-eject an initialy inserted iso in staging-4.2

[Jungnam Lee]

[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]

Hi all.
I created VM with a cdrom device with an iso file, and ejecting works fine in the master branch.
But if I do this with staging-4.2, I got an error below.
libxl: debug: libxl.c:2137:libxl_cdrom_insert: ao 0x1425990: create: how=(nil) callback=(nil) poller=0x14259f0
libxl: debug: libxl_device.c:245:libxl__device_disk_set_backend: Disk vdev=hdc spec.backend=phy
libxl: debug: libxl_device.c:191:disk_try_backend: Disk vdev=hdc, backend phy unsuitable as phys path not a block device
libxl: error: libxl_device.c:285:libxl__device_disk_set_backend: no suitable backend for disk hdc.

cd-insert and cd-eject works fine when it is created with an empty cdrom device, and xl says its backend is qdisk.
But when it is created with an iso inserted cdrom device, it says backend is unknown.
I dont know whether I report this as a bug, so I just mail this.

[-- Attachment #1.2: Type: text/html, Size: 1286 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: xl cannot cd-eject an initialy inserted iso in staging-4.2

[George Dunlap]

[-- Attachment #1.1: Type: text/plain, Size: 842 bytes --]

On Fri, Mar 7, 2014 at 2:47 AM, Jungnam Lee <jungnam.lee@kaist.ac.kr> wrote:

>  Hi all.
>
> I created VM with a cdrom device with an iso file, and ejecting works fine
> in the master branch.
>
> But if I do this with staging-4.2, I got an error below.
>
> libxl: debug: libxl.c:2137:libxl_cdrom_insert: ao 0x1425990: create:
> how=(nil) callback=(nil) poller=0x14259f0
>
> libxl: debug: libxl_device.c:245:libxl__device_disk_set_backend: Disk
> vdev=hdc spec.backend=phy
>
> libxl: debug: libxl_device.c:191:disk_try_backend: Disk vdev=hdc, backend
> phy unsuitable as phys path not a block device
>
> libxl: error: libxl_device.c:285:libxl__device_disk_set_backend: no
> suitable backend for disk hdc.
>

Does the patch from this mail help?

I had tried to flag it as a candidate for backport at the time, but I
failed to CC Jan.

 -George

[-- Attachment #1.2: Type: text/html, Size: 1322 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: xl cannot cd-eject an initialy inserted iso in staging-4.2

[Ian Campbell]

On Tue, 2014-03-11 at 12:26 +0000, George Dunlap wrote:

> 
> Does the patch from this mail help?

this? Missing a reference/footnote?

Re: xl cannot cd-eject an initialy inserted iso in staging-4.2

[George Dunlap]

On 03/11/2014 01:59 PM, Ian Campbell wrote:
> On Tue, 2014-03-11 at 12:26 +0000, George Dunlap wrote:
>
>>
>> Does the patch from this mail help?
>
> this? Missing a reference/footnote?

Hrm, strange, I thought I'd pasted it in...

Anyway:

http://marc.info/?l=xen-devel&m=136749268413332

(Msg-id <1367492589-28970-1-git-send-email-george.dunlap@eu.citrix.com> )


  -George

Re: xl cannot cd-eject an initialy inserted iso in staging-4.2

[Jan Beulich]

>>> On 11.03.14 at 13:26, George Dunlap <George.Dunlap@eu.citrix.com> wrote:
> On Fri, Mar 7, 2014 at 2:47 AM, Jungnam Lee <jungnam.lee@kaist.ac.kr> wrote:
> 
>>  Hi all.
>>
>> I created VM with a cdrom device with an iso file, and ejecting works fine
>> in the master branch.
>>
>> But if I do this with staging-4.2, I got an error below.
>>
>> libxl: debug: libxl.c:2137:libxl_cdrom_insert: ao 0x1425990: create:
>> how=(nil) callback=(nil) poller=0x14259f0
>>
>> libxl: debug: libxl_device.c:245:libxl__device_disk_set_backend: Disk
>> vdev=hdc spec.backend=phy
>>
>> libxl: debug: libxl_device.c:191:disk_try_backend: Disk vdev=hdc, backend
>> phy unsuitable as phys path not a block device
>>
>> libxl: error: libxl_device.c:285:libxl__device_disk_set_backend: no
>> suitable backend for disk hdc.
>>
> 
> Does the patch from this mail help?
> 
> I had tried to flag it as a candidate for backport at the time, but I
> failed to CC Jan.

And you really would have needed to Cc IanJ, as he's who takes
care of tools side backports.

Jan

Re: xl cannot cd-eject an initialy inserted iso in staging-4.2

[George Dunlap]

On 03/11/2014 02:13 PM, Jan Beulich wrote:
>>>> On 11.03.14 at 13:26, George Dunlap <George.Dunlap@eu.citrix.com> wrote:
>> On Fri, Mar 7, 2014 at 2:47 AM, Jungnam Lee <jungnam.lee@kaist.ac.kr> wrote:
>>
>>>   Hi all.
>>>
>>> I created VM with a cdrom device with an iso file, and ejecting works fine
>>> in the master branch.
>>>
>>> But if I do this with staging-4.2, I got an error below.
>>>
>>> libxl: debug: libxl.c:2137:libxl_cdrom_insert: ao 0x1425990: create:
>>> how=(nil) callback=(nil) poller=0x14259f0
>>>
>>> libxl: debug: libxl_device.c:245:libxl__device_disk_set_backend: Disk
>>> vdev=hdc spec.backend=phy
>>>
>>> libxl: debug: libxl_device.c:191:disk_try_backend: Disk vdev=hdc, backend
>>> phy unsuitable as phys path not a block device
>>>
>>> libxl: error: libxl_device.c:285:libxl__device_disk_set_backend: no
>>> suitable backend for disk hdc.
>>>
>>
>> Does the patch from this mail help?
>>
>> I had tried to flag it as a candidate for backport at the time, but I
>> failed to CC Jan.
>
> And you really would have needed to Cc IanJ, as he's who takes
> care of tools side backports.

Ah, right -- well I did CC IanJ; not in the original message, but when I 
replied saying "This should probably be backported".

(I'm not 100% sure it wasn't backported: a quick search through the git 
history didn't turn up anything, but I may have missed it.)

  -George

Re: xl cannot cd-eject an initialy inserted iso in staging-4.2

[Jungnam Lee]

2014-03-11, 14:48 +0000, George Dunlap:
> On 03/11/2014 02:13 PM, Jan Beulich wrote:
> >>>> On 11.03.14 at 13:26, George Dunlap <George.Dunlap@eu.citrix.com> wrote:
> >> On Fri, Mar 7, 2014 at 2:47 AM, Jungnam Lee <jungnam.lee@kaist.ac.kr> wrote:
> >>
> >>>   Hi all.
> >>>
> >>> I created VM with a cdrom device with an iso file, and ejecting works fine
> >>> in the master branch.
> >>>
> >>> But if I do this with staging-4.2, I got an error below.
> >>>
> >>> libxl: debug: libxl.c:2137:libxl_cdrom_insert: ao 0x1425990: create:
> >>> how=(nil) callback=(nil) poller=0x14259f0
> >>>
> >>> libxl: debug: libxl_device.c:245:libxl__device_disk_set_backend: Disk
> >>> vdev=hdc spec.backend=phy
> >>>
> >>> libxl: debug: libxl_device.c:191:disk_try_backend: Disk vdev=hdc, backend
> >>> phy unsuitable as phys path not a block device
> >>>
> >>> libxl: error: libxl_device.c:285:libxl__device_disk_set_backend: no
> >>> suitable backend for disk hdc.
> >>>
> >>
> >> Does the patch from this mail help?
> >>
> >> I had tried to flag it as a candidate for backport at the time, but I
> >> failed to CC Jan.
> >
> > And you really would have needed to Cc IanJ, as he's who takes
> > care of tools side backports.
> 
> Ah, right -- well I did CC IanJ; not in the original message, but when I 
> replied saying "This should probably be backported".
> 
> (I'm not 100% sure it wasn't backported: a quick search through the git 
> history didn't turn up anything, but I may have missed it.)
> 

it seems cherry-picking 0166217103e18368424fbd5ffff01c1ea50d0b17 fixes
this issue. Is this right?

Re: xl cannot cd-eject an initialy inserted iso in staging-4.2

[George Dunlap]

On 03/13/2014 07:20 AM, Jungnam Lee wrote:
> 2014-03-11, 14:48 +0000, George Dunlap:
>> On 03/11/2014 02:13 PM, Jan Beulich wrote:
>>>>>> On 11.03.14 at 13:26, George Dunlap <George.Dunlap@eu.citrix.com> wrote:
>>>> On Fri, Mar 7, 2014 at 2:47 AM, Jungnam Lee <jungnam.lee@kaist.ac.kr> wrote:
>>>>
>>>>>    Hi all.
>>>>>
>>>>> I created VM with a cdrom device with an iso file, and ejecting works fine
>>>>> in the master branch.
>>>>>
>>>>> But if I do this with staging-4.2, I got an error below.
>>>>>
>>>>> libxl: debug: libxl.c:2137:libxl_cdrom_insert: ao 0x1425990: create:
>>>>> how=(nil) callback=(nil) poller=0x14259f0
>>>>>
>>>>> libxl: debug: libxl_device.c:245:libxl__device_disk_set_backend: Disk
>>>>> vdev=hdc spec.backend=phy
>>>>>
>>>>> libxl: debug: libxl_device.c:191:disk_try_backend: Disk vdev=hdc, backend
>>>>> phy unsuitable as phys path not a block device
>>>>>
>>>>> libxl: error: libxl_device.c:285:libxl__device_disk_set_backend: no
>>>>> suitable backend for disk hdc.
>>>>>
>>>> Does the patch from this mail help?
>>>>
>>>> I had tried to flag it as a candidate for backport at the time, but I
>>>> failed to CC Jan.
>>> And you really would have needed to Cc IanJ, as he's who takes
>>> care of tools side backports.
>> Ah, right -- well I did CC IanJ; not in the original message, but when I
>> replied saying "This should probably be backported".
>>
>> (I'm not 100% sure it wasn't backported: a quick search through the git
>> history didn't turn up anything, but I may have missed it.)
>>
> it seems cherry-picking 0166217103e18368424fbd5ffff01c1ea50d0b17 fixes
> this issue. Is this right?

Ah, right -- I think that's the one I was looking for actually.  I 
forgot that Wei had written it, not me.

  -George