xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "keir@xen.org" <keir@xen.org>,
	"jbeulich@suse.com" <jbeulich@suse.com>,
	"stefano.stabellini@eu.citrix.com"
	<stefano.stabellini@eu.citrix.com>,
	"Dong, Eddie" <eddie.dong@intel.com>,
	"ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	"Nakajima, Jun" <jun.nakajima@intel.com>,
	"ian.campbell@citrix.com" <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 0/4] Expose HW APIC virtualization support to	HVM guests
Date: Tue, 11 Mar 2014 10:32:36 -0400	[thread overview]
Message-ID: <531F1E84.3030603@oracle.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E0AA11E39@SHSMSX104.ccr.corp.intel.com>

On 03/11/2014 03:37 AM, Zhang, Yang Z wrote:
> Boris Ostrovsky wrote on 2014-03-11:
>> Version 2:
>> * Added ability to specify hypervisor CPUID leaves in config file (this requires
>>    new sysctl)
>> * Use 2 bits to indicate what is supported --- one for APIC memory access and
>> the
>>    other for x2APIC. Still not sure whether virtual interrupt delivery should be
>>    exposed as well.
>>
>> ...
>>
>> I am also not sure whether (cpu_has_vmx_apic_reg_virt &
>> cpu_has_vmx_virtualize_x2apic_mode) is sufficient to declare full HW
>> APIC support to a guest. The tests show ~95K VMEXITs when virtual
> The former is enough. Hardware has APICv must have the virtualize x2apic too.
>
>> interrupt delivery and posted interrupts are turned off so there
>> appears to still be some benefit. I suppose we can use another CPUID
>> bit for these two (although I am not particularly eager to do this).
> The three features are coexisting. I think you can use one bit to show them.

As I learned yesterday (the hard way) this is not necessarily the case. 
I was testing this on a laptop that has MSR 0x48b 
(MSR_IA32_VMX_PROCBASED_CTLS2) return 0x8ff00000000: yes for x2APIC 
virtualization but no for APIC register access virtualization.

Which is why I added another bit to distinguish the two


Thanks.
-boris

  reply	other threads:[~2014-03-11 14:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11  3:53 [PATCH v2 0/4] Expose HW APIC virtualization support to HVM guests Boris Ostrovsky
2014-03-11  3:54 ` [PATCH v2 1/4] xen/libxc: Allow changes to hypervisor CPUID leaf from config file Boris Ostrovsky
2014-03-11  8:45   ` Jan Beulich
2014-03-11 14:24     ` Boris Ostrovsky
2014-03-11 10:10   ` Andrew Cooper
2014-03-11 14:07     ` Boris Ostrovsky
2014-03-11 14:26       ` Andrew Cooper
2014-03-11 14:48         ` Boris Ostrovsky
2014-03-11 16:19         ` Jan Beulich
2014-03-11  3:54 ` [PATCH v2 2/4] x86/hvm: Revert 80ecb40362365ba77e68fc609de8bd3b7208ae19 Boris Ostrovsky
2014-03-11  3:54 ` [PATCH v2 3/4] x86/hvm: Add HVM-specific hypervisor CPUID leaf Boris Ostrovsky
2014-03-11  3:54 ` [PATCH v2 4/4] x86/hvm: Indicate avaliability of HW support of APIC virtualization to HVM guests Boris Ostrovsky
2014-03-11  7:37 ` [PATCH v2 0/4] Expose HW APIC virtualization support " Zhang, Yang Z
2014-03-11 14:32   ` Boris Ostrovsky [this message]
2014-03-11 11:00 ` David Vrabel
2014-03-11 14:14   ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531F1E84.3030603@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=eddie.dong@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).