From: Julien Grall <julien.grall@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>,
stefano.stabellini@citrix.com, ian.campbell@citrix.com,
tim@xen.org
Subject: Re: [PATCH v3 4/5] xen/console: Add support for early printk
Date: Wed, 12 Mar 2014 15:32:57 +0000 [thread overview]
Message-ID: <53207E29.9060209@linaro.org> (raw)
In-Reply-To: <5320893402000078001234E4@nat28.tlf.novell.com>
Hi Jan,
On 03/12/2014 03:20 PM, Jan Beulich wrote:
>>>> On 12.03.14 at 15:34, Julien Grall <julien.grall@linaro.org> wrote:
>> --- /dev/null
>> +++ b/xen/include/xen/early_printk.h
>> @@ -0,0 +1,21 @@
>> +/*
>> + * printk() for use before the console is initialized
>> + */
>> +#ifndef __XEN_EARLY_PRINTK_H__
>> +#define __XEN_EARLY_PRINTK_H__
>> +
>> +#ifdef CONFIG_EARLY_PRINTK
>> +void early_puts(const char *s);
>> +#else
>> +static inline void early_puts(const char *s) {};
>
> Considering that the only (source) use of the function is to take its
> address, using an inline function for that purpose is bogus. Either
> #define it to NULL (thus leaving the serial_steal_fn initializer
> unchanged for x86) or have it be a static __init function in
> xen/drivers/char/console.c, conditional upon !CONFIG_EARLY_PRINTK.
Right, I will fix it for the next version of this patch.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-03-12 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 14:34 [PATCH v3 0/5] xen/arm: Merge early_printk function in console code Julien Grall
2014-03-12 14:34 ` [PATCH v3 1/5] xen/arm: earlyprintk: move early_flush in early_puts Julien Grall
2014-03-12 14:34 ` [PATCH v3 2/5] xen/arm: earlyprintk: export early_puts Julien Grall
2014-03-12 14:34 ` [PATCH v3 3/5] xen/arm: Rename EARLY_PRINTK compile option to CONFIG_EARLY_PRINTK Julien Grall
2014-03-12 14:34 ` [PATCH v3 4/5] xen/console: Add support for early printk Julien Grall
2014-03-12 15:20 ` Jan Beulich
2014-03-12 15:32 ` Julien Grall [this message]
2014-03-12 14:34 ` [PATCH v3 5/5] xen/arm: Replace early_{printk, panic} call to {printk, panic} call Julien Grall
2014-03-12 15:15 ` [PATCH v3 0/5] xen/arm: Merge early_printk function in console code Jan Beulich
2014-03-12 15:31 ` Julien Grall
2014-03-12 16:44 ` Jan Beulich
2014-03-12 16:52 ` Ian Campbell
2014-03-14 14:42 ` Ian Campbell
2014-03-14 15:42 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53207E29.9060209@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).