xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Konieczny <jajcus@jajcus.net>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
	"Jan Rękorajski" <baggins@pld-linux.org>,
	"Ian Jackson" <ian.jackson@eu.citrix.com>,
	"M A Young" <m.a.young@durham.ac.uk>,
	xen-devel@lists.xenproject.org,
	"Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Subject: Re: [PATCH] systemd: add support initial systemd service files
Date: Thu, 13 Mar 2014 10:55:01 +0100	[thread overview]
Message-ID: <53218075.3020004@jajcus.net> (raw)
In-Reply-To: <1394704346.3457.32.camel@kazak.uk.xensource.com>

On 03/13/14 10:52, Ian Campbell wrote:
> On Thu, 2014-03-13 at 09:03 +0100, Jacek Konieczny wrote:
>> On 03/13/14 01:06, Luis R. Rodriguez wrote:
>>> On Wed, Mar 12, 2014 at 5:01 PM, M A Young <m.a.young@durham.ac.uk> wrote:
>>>>> But this didn't seem to work, I suppose I'm not using the variables
>>>>> correctly.
>>>>
>>>>
>>>> Systemd only provides limited variable support - you can use them for
>>>> arguments but not the executables.
>>>
>>> Not even the path to the executables ? ie $FOO/bar
>>
>> No, and there are some good reasons for that.
>> And if anybody really needs to change that after installation, he may
>> copy the unit files from /lib/systemd/system to /etc/systemd/system and
>> edit them.
>>
>> Other way would be to use generators to dynamically build the units, but
>> I really don't thing there is a good reason for having the paths
>> dynamic.
> 
> Would it be preferable to have the Xen build system produce foo.service
> from foo.service.in doing the variable substitution at build time?

Yes, IMHO, that is the right way to do this.

Greets,
Jacek

  reply	other threads:[~2014-03-13  9:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-12  0:03 [PATCH] systemd: add support initial systemd service files Luis R. Rodriguez
2014-03-12  8:16 ` Jacek Konieczny
2014-03-12  8:35   ` Luis R. Rodriguez
2014-03-12  9:07     ` Jacek Konieczny
2014-03-12  9:19       ` Luis R. Rodriguez
2014-03-12 11:24         ` Jan Rękorajski
2014-03-12 11:22       ` Ian Campbell
2014-03-12 19:44         ` M A Young
2014-03-12 23:43           ` Luis R. Rodriguez
2014-03-13  0:37             ` M A Young
2014-03-12 23:53           ` Luis R. Rodriguez
2014-03-13  0:01             ` M A Young
2014-03-13  0:06               ` Luis R. Rodriguez
2014-03-13  8:03                 ` Jacek Konieczny
2014-03-13  9:52                   ` Ian Campbell
2014-03-13  9:55                     ` Jacek Konieczny [this message]
2014-03-12 11:14   ` Ian Jackson
2014-03-12 11:25     ` Ian Campbell
2014-03-12 11:42       ` Andrew Cooper
2014-03-12 18:35         ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53218075.3020004@jajcus.net \
    --to=jajcus@jajcus.net \
    --cc=Ian.Campbell@citrix.com \
    --cc=baggins@pld-linux.org \
    --cc=ian.jackson@eu.citrix.com \
    --cc=m.a.young@durham.ac.uk \
    --cc=mcgrof@do-not-panic.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).