From: George Dunlap <george.dunlap@eu.citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Eddie Dong <eddie.dong@intel.com>, Keir Fraser <keir@xen.org>,
Jun Nakajima <jun.nakajima@intel.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 1/5] xen: Remove redundant __attribute__((packed)) statements
Date: Thu, 13 Mar 2014 10:49:04 +0000 [thread overview]
Message-ID: <53218D20.3060507@eu.citrix.com> (raw)
In-Reply-To: <1394651319-8893-2-git-send-email-andrew.cooper3@citrix.com>
On 03/12/2014 07:08 PM, Andrew Cooper wrote:
> All of these structure packing statements are redundant, and was confirmed by
> diffing xen-syms with and without the change in place.
>
> Removing struct xgt_desc in its entirety (as it was unreferenced) results in
> shuffling the symbol index, but makes no change to the code.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
I guess I'm becoming a crotchety old maintainer; at least re the tracing
code, I don't see how the cost -- your initial effort in figuring out
which structures need packing, the cost of review time, and the risk of
regression, no matter how small -- is worth the benefit. It seems to me
like having all the tracing structures tagged with "__packed" will
remind people to think about packing when they're writing or modifying
structures.
But if Jan and/or Keir think it's a good idea, and are satisfied that
it's correct, I won't oppose it.
-George
next prev parent reply other threads:[~2014-03-13 10:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 19:08 [PATCH 0/5] Improvements with __attribute__((packed)) Andrew Cooper
2014-03-12 19:08 ` [PATCH 1/5] xen: Remove redundant __attribute__((packed)) statements Andrew Cooper
2014-03-13 8:06 ` Jan Beulich
2014-03-13 10:38 ` Andrew Cooper
2014-03-13 10:49 ` George Dunlap [this message]
2014-03-12 19:08 ` [PATCH 2/5] xen/common: Cleanup use of __attribute__((packed)) Andrew Cooper
2014-03-13 8:15 ` Jan Beulich
2014-03-13 10:22 ` Andrew Cooper
2014-03-13 10:40 ` Jan Beulich
2014-03-13 10:42 ` Andrew Cooper
2014-03-12 19:08 ` [PATCH 3/5] xen/x86: " Andrew Cooper
2014-03-13 8:32 ` Jan Beulich
2014-03-13 11:00 ` Andrew Cooper
2014-03-13 11:13 ` Jan Beulich
2014-03-13 11:36 ` Keir Fraser
2014-03-12 19:08 ` [PATCH 4/5] xen/arm: " Andrew Cooper
2014-03-13 8:34 ` Jan Beulich
2014-03-13 9:55 ` Ian Campbell
2014-03-13 9:59 ` Tim Deegan
2014-03-13 10:01 ` Ian Campbell
2014-03-13 10:02 ` Jan Beulich
2014-03-12 19:08 ` [PATCH 5/5] DO NOT APPLY: for verification purposes only Andrew Cooper
2014-03-13 6:31 ` [PATCH 0/5] Improvements with __attribute__((packed)) Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53218D20.3060507@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).