From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>,
stefano.stabellini@eu.citrix.com, tim@xen.org,
george.dunlap@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: arm: increase priority of SGIs used as IPIs
Date: Thu, 13 Mar 2014 12:33:21 +0000 [thread overview]
Message-ID: <5321A591.3030400@linaro.org> (raw)
In-Reply-To: <1390927878-7048-1-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 01/28/2014 04:51 PM, Ian Campbell wrote:
> /* Set PPI and SGI priorities */
> - for (i = 0; i < 32; i += 4)
> - GICD[GICD_IPRIORITYR + i / 4] = 0xa0a0a0a0;
> + for (i = 0; i < 16; i += 4)
> + GICD[GICD_IPRIORITYR + i / 4] =
> + GIC_PRI_IPI<<24 | GIC_PRI_IPI<<16 | GIC_PRI_IPI<<8 | GIC_PRI_IPI;
> + for (i = 16; i < 32; i += 4)
> + GICD[GICD_IPRIORITYR + i / 4] =
> + GIC_PRI_IRQ<<24 | GIC_PRI_IRQ<<16 | GIC_PRI_IRQ<<8 | GIC_PRI_IRQ;
I'm wondering if it's necessary to set the priority for PPIs. It will be
overridden later when the interrupt will be setup. Until that time, the
interrupt is not enabled.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-03-13 12:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 16:51 [PATCH] xen: arm: increase priority of SGIs used as IPIs Ian Campbell
2014-01-28 16:51 ` Ian Campbell
2014-01-28 17:50 ` Stefano Stabellini
2014-01-28 18:20 ` Oleksandr Tyshchenko
2014-03-13 12:26 ` Ian Campbell
2014-03-13 12:33 ` Julien Grall [this message]
2014-03-13 12:45 ` Ian Campbell
2014-03-13 12:56 ` Julien Grall
2014-03-13 13:35 ` Oleksandr Tyshchenko
2014-03-16 16:38 ` Stefano Stabellini
2014-03-17 10:02 ` Ian Campbell
2014-03-17 11:29 ` Ian Campbell
2014-03-17 11:34 ` Julien Grall
2014-03-17 11:36 ` Ian Campbell
2014-03-17 12:42 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321A591.3030400@linaro.org \
--to=julien.grall@linaro.org \
--cc=george.dunlap@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=oleksandr.tyshchenko@globallogic.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).