From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen: arm: increase priority of SGIs used as IPIs Date: Thu, 13 Mar 2014 12:56:36 +0000 Message-ID: <5321AB04.1020809@linaro.org> References: <1390927878-7048-1-git-send-email-ian.campbell@citrix.com> <5321A591.3030400@linaro.org> <1394714754.25873.61.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394714754.25873.61.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Oleksandr Tyshchenko , stefano.stabellini@eu.citrix.com, tim@xen.org, george.dunlap@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 03/13/2014 12:45 PM, Ian Campbell wrote: > On Thu, 2014-03-13 at 12:33 +0000, Julien Grall wrote: >> Hi Ian, >> >> On 01/28/2014 04:51 PM, Ian Campbell wrote: >>> /* Set PPI and SGI priorities */ >>> - for (i = 0; i < 32; i += 4) >>> - GICD[GICD_IPRIORITYR + i / 4] = 0xa0a0a0a0; >>> + for (i = 0; i < 16; i += 4) >>> + GICD[GICD_IPRIORITYR + i / 4] = >>> + GIC_PRI_IPI<<24 | GIC_PRI_IPI<<16 | GIC_PRI_IPI<<8 | GIC_PRI_IPI; >>> + for (i = 16; i < 32; i += 4) >>> + GICD[GICD_IPRIORITYR + i / 4] = >>> + GIC_PRI_IRQ<<24 | GIC_PRI_IRQ<<16 | GIC_PRI_IRQ<<8 | GIC_PRI_IRQ; >> >> I'm wondering if it's necessary to set the priority for PPIs. It will be >> overridden later when the interrupt will be setup. Until that time, the >> interrupt is not enabled. > > Strictly speaking probably not, but there isn't much harm in setting a > sane default I suppose. Right, I didn't see that we also do that for SPIs. I have a minor change to request, can you divide the comment "Set PPI and SGI priorities" in 2 to reflect was does each loop? Except that: Acked-by: Julien Grall Regards, -- Julien Grall