From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH v2 5/5] xen/x86_emulate: Shuffle use of __attribute__((packed)) Date: Thu, 13 Mar 2014 16:08:13 +0000 Message-ID: <5321D7ED.5070309@gmail.com> References: <1394723060-24158-1-git-send-email-andrew.cooper3@citrix.com> <1394723060-24158-6-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8237655970321370522==" Return-path: In-Reply-To: <1394723060-24158-6-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Ian Jackson , Keir Fraser , Ian Campbell , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============8237655970321370522== Content-Type: multipart/alternative; boundary="------------090104050605030004020103" This is a multi-part message in MIME format. --------------090104050605030004020103 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Andrew Cooper wrote: > > Also include #defines for the test code to allow compilation. > > Signed-off-by: Andrew Cooper > CC: Keir Fraser > CC: Jan Beulich > CC: Ian Campbell > CC: Ian Jackson > > --- > > I have mixed thoughts about this, which is why it is explicit > separated from > the rest of the series. On the one hand, consistency is good but on the > other, it makes x86_emulate harder to use as a dropin in other code. We already have a bunch of external definitions that must be provided for x86_emulate.c. This merely adds another, but which is required for x86_emulate.h. So it's perfectly fine by me. Acked-by: Keir Fraser --------------090104050605030004020103 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Andrew Cooper wrote:

Also include #defines for the test code to allow compilation.

Signed-off-by: Andrew Cooper<andrew.cooper3@citrix.com>
CC: Keir Fraser<keir@xen.org>
CC: Jan Beulich<JBeulich@suse.com>
CC: Ian Campbell<Ian.Campbell@citrix.com>
CC: Ian Jackson<Ian.Jackson@eu.citrix.com>

---

I have mixed thoughts about this, which is why it is explicit separated from
the rest of the series.  On the one hand, consistency is good but on the
other, it makes x86_emulate harder to use as a dropin in other code.


We already have a bunch of external definitions that must be provided for x86_emulate.c. This merely adds another, but which is required for x86_emulate.h. So it's perfectly fine by me.

Acked-by: Keir Fraser <keir@xen.org>
--------------090104050605030004020103-- --===============8237655970321370522== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8237655970321370522==--