From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 1/5] xen/misc: Functional cleanup for
 __attribute__((packed)) changes
Date: Thu, 13 Mar 2014 16:30:19 +0000
Message-ID: <5321DD1B.7020409@citrix.com>
References: <1394723060-24158-1-git-send-email-andrew.cooper3@citrix.com>
	<1394723060-24158-2-git-send-email-andrew.cooper3@citrix.com>
	<5321E93F0200007800123D86@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5321E93F0200007800123D86@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, JunNakajima <jun.nakajima@intel.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 13/03/14 16:22, Jan Beulich wrote:
>>>> On 13.03.14 at 16:04, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/arch/x86/cpu/mcheck/mce-apei.c
>> +++ b/xen/arch/x86/cpu/mcheck/mce-apei.c
>> @@ -53,7 +53,7 @@ struct cper_mce_record {
>>  	struct cper_record_header hdr;
>>  	struct cper_section_descriptor sec_hdr;
>>  	struct mce mce;
>> -} __packed;
>> +} __attribute__((packed));
>>  /* Reset to default packing */
>>  #pragma pack()
> I'm sorry for paying attention only now, but you apparently didn't
> notice this either: The #pragma pack() around that structure was
> the apparent attempt to deal with __packed "not functioning". We
> should get rig of these pragmas at the same time I think.
>
> Jan
>

I did notice that, but was hoping to ignore it for the time being (as
this __packed series has become rather longer than the half hour task I
planned it to be)

I shall do a new following patch which replaces the use of #pragma
pack() in Xen, which doesn't look too difficult.

~Andrew