From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>,
Keir Fraser <keir@xen.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] stubdom/libxc: Fix build of unsafe decompressors
Date: Fri, 14 Mar 2014 11:31:58 +0000 [thread overview]
Message-ID: <5322E8AE.808@citrix.com> (raw)
In-Reply-To: <1394796221.6442.32.camel@kazak.uk.xensource.com>
On 14/03/14 11:23, Ian Campbell wrote:
> On Fri, 2014-03-14 at 11:16 +0000, Andrew Cooper wrote:
>> c/s b683d68c386 changed the packing attribute on struct lzma_header.
> Since this is third party code (which presumably we want to keep mostly
> in sync) was this a good idea?
It seemed so at the time
> Perhaps we should just revert that portion?
That might be be the easiest option.
Frankly, my opinion is that anything under xen/ is fair game for having
hypervisor style and consistency applied to it. It should be reasonable
to expect that any code under xen/ is exclusive to the hypervisor, and
the real issue is having library code not obviously separated.
v2 patch on its way.
~Andrew
next prev parent reply other threads:[~2014-03-14 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 11:16 [PATCH] stubdom/libxc: Fix build of unsafe decompressors Andrew Cooper
2014-03-14 11:23 ` Ian Campbell
2014-03-14 11:31 ` Andrew Cooper [this message]
2014-03-14 11:43 ` [PATCH] xen/unlzma: Fix build of stubdom " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322E8AE.808@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=linux@eikelenboom.it \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).