xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Andrii Anisov <andrii.anisov@globallogic.com>
Cc: Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Tim Deegan <tim@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Restart domU failure (memory allocation issue)
Date: Fri, 14 Mar 2014 14:17:58 +0000	[thread overview]
Message-ID: <53230F96.9070400@linaro.org> (raw)
In-Reply-To: <CAGQvs6gJ4ZW5kLr7VZ8kNfEk_MsXRYNz2wqnWrFfra4nkHDnoA@mail.gmail.com>

On 03/14/2014 02:05 PM, Andrii Anisov wrote:
>     This is done in kernel space. When you map the pages, privcmd will set
>     specific callbacks that will be use when munmap will be called (see
>     privcmd_close in drivers/xen/privcmd.c).
>     The privcmd_close function will call the hypercall to remove the foreign
>     page from the p2m.
> 
> 
> We will check if it works on our site (but it looks it does not).

I think I've found why ... the privcmd_close is buggy on 3.8. You might
need to backport this commit:

commit 9eff37a8713939f218ab8bf0dc93f1d67af7b8b4
Author: Dan Carpenter <dan.carpenter@oracle.com>
Date:   Mon Nov 5 09:42:17 2012 +0300

    xen/privcmd: fix condition in privcmd_close()
    
    The parenthesis are in the wrong place so the original code is
    equivalent to:
    
        if (!xen_feature(XENFEAT_writable_descriptor_tables)) { ...
    
    Which obviously was not intended.
    
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Regards,

-- 
Julien Grall

  reply	other threads:[~2014-03-14 14:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13 18:33 Restart domU failure (memory allocation issue) Oleksandr Tyshchenko
2014-03-13 19:48 ` Julien Grall
2014-03-14 11:10   ` Andrii Anisov
2014-03-14 11:14     ` Andrii Anisov
2014-03-14 12:15       ` Julien Grall
2014-03-14 12:45         ` Andrii Anisov
2014-03-14 14:00           ` Julien Grall
2014-03-14 14:05             ` Andrii Anisov
2014-03-14 14:17               ` Julien Grall [this message]
2014-03-14 14:37                 ` Oleksandr Tyshchenko
2014-03-14 14:08             ` Oleksandr Tyshchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53230F96.9070400@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=andrii.anisov@globallogic.com \
    --cc=oleksandr.tyshchenko@globallogic.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).