From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: Restart domU failure (memory allocation issue)
Date: Fri, 14 Mar 2014 14:17:58 +0000
Message-ID: <53230F96.9070400@linaro.org>
References: <CAJEb2DHt0B84mA4_2Ovvvjpqu03Od5oG1WRvRVNNiZcum0FuYA@mail.gmail.com>
	<53220B9A.50508@linaro.org>
	<CAGQvs6g+c1ieLMpwq7on8r6RqxcnUNxpRG=OHk5rOjehcBQJjg@mail.gmail.com>
	<CAGQvs6hT-8nS4cfhqNbJsEeDXsnjEwrJn3WmB7FLLT+wTmMqhg@mail.gmail.com>
	<5322F2D5.9020906@linaro.org>
	<CAGQvs6iZr3G83ZRVi0X1VLPER7w8p=QfFU5F9ZDXAtdx3XFNQg@mail.gmail.com>
	<53230B74.6090105@linaro.org>
	<CAGQvs6gJ4ZW5kLr7VZ8kNfEk_MsXRYNz2wqnWrFfra4nkHDnoA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAGQvs6gJ4ZW5kLr7VZ8kNfEk_MsXRYNz2wqnWrFfra4nkHDnoA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrii Anisov <andrii.anisov@globallogic.com>
Cc: Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 03/14/2014 02:05 PM, Andrii Anisov wrote:
>     This is done in kernel space. When you map the pages, privcmd will set
>     specific callbacks that will be use when munmap will be called (see
>     privcmd_close in drivers/xen/privcmd.c).
>     The privcmd_close function will call the hypercall to remove the foreign
>     page from the p2m.
> 
> 
> We will check if it works on our site (but it looks it does not).

I think I've found why ... the privcmd_close is buggy on 3.8. You might
need to backport this commit:

commit 9eff37a8713939f218ab8bf0dc93f1d67af7b8b4
Author: Dan Carpenter <dan.carpenter@oracle.com>
Date:   Mon Nov 5 09:42:17 2012 +0300

    xen/privcmd: fix condition in privcmd_close()
    
    The parenthesis are in the wrong place so the original code is
    equivalent to:
    
        if (!xen_feature(XENFEAT_writable_descriptor_tables)) { ...
    
    Which obviously was not intended.
    
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Regards,

-- 
Julien Grall