From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 07/14] xen/xsm: flask: Fix compilation when CONFIG_COMPAT=y Date: Mon, 17 Mar 2014 11:57:57 +0000 Message-ID: <5326E345.3060605@linaro.org> References: <1394640969-25583-1-git-send-email-julien.grall@linaro.org> <1394640969-25583-8-git-send-email-julien.grall@linaro.org> <5321C024.1070703@tycho.nsa.gov> <1394817798.6065.10.camel@kazak.uk.xensource.com> <5326B0D70200007800124882@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WPWB6-0002Jc-NK for xen-devel@lists.xenproject.org; Mon, 17 Mar 2014 11:58:00 +0000 Received: by mail-we0-f173.google.com with SMTP id w61so4478763wes.32 for ; Mon, 17 Mar 2014 04:57:59 -0700 (PDT) In-Reply-To: <5326B0D70200007800124882@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Daniel De Graaf , stefano.stabellini@citrix.com, Ian Campbell , tim@xen.org List-Id: xen-devel@lists.xenproject.org Hi Jan, On 03/17/2014 07:22 AM, Jan Beulich wrote: > The construct is appropriate here (albeit I'd switch the operands > of &&) - elsewhere inclusion goes indirectly, with the two checks > in distinct places. It didn't seem worthwhile introducing a separate > file here for the compat mode wrapping, so the check can validly > be done in a single conditional. I will switch the operand in the next version. Regards, -- Julien Grall