From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 06/13] xen/passthrough: iommu: Split generic IOMMU code Date: Tue, 18 Mar 2014 17:36:35 +0000 Message-ID: <53288423.8040407@linaro.org> References: <1394552999-14171-1-git-send-email-julien.grall@linaro.org> <1394552999-14171-7-git-send-email-julien.grall@linaro.org> <1395159874.11824.5.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WPxwN-0005xu-19 for xen-devel@lists.xenproject.org; Tue, 18 Mar 2014 17:36:39 +0000 Received: by mail-wi0-f175.google.com with SMTP id cc10so4039561wib.2 for ; Tue, 18 Mar 2014 10:36:37 -0700 (PDT) In-Reply-To: <1395159874.11824.5.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Jan Beulich , tim@xen.org, Xiantao Zhang , stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 03/18/2014 04:24 PM, Ian Campbell wrote: > On Tue, 2014-03-11 at 15:49 +0000, Julien Grall wrote: >> The generic IOMMU framework code (xen/drivers/passthrough/iommu.c) contains >> functions specific to x86 and PCI. >> >> Split the framework in 3 distincts files: >> - iommu.c: contains generic functions shared between x86 and ARM >> (when it will be supported) >> - pci.c: contains specific functions for PCI passthrough >> - x86/iommu.c: contains specific functions for x86 >> >> io.c contains x86 HVM specific code. Only compile for x86. > > Move it to x86/io.c then ? For now it contains mostly x86 code. The file contains function handle handle pt_irq. I'm not 100% sure if we will need some part for ARM. Regards, -- Julien Grall