From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 07/13] xen/passthrough: iommu: Introduce
 arch specific code
Date: Tue, 18 Mar 2014 19:40:29 +0000
Message-ID: <5328A12D.2070501@linaro.org>
References: <1394552999-14171-1-git-send-email-julien.grall@linaro.org>
	<1394552999-14171-8-git-send-email-julien.grall@linaro.org>
	<1395160052.11824.7.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WPzsH-0003Av-FM
	for xen-devel@lists.xenproject.org; Tue, 18 Mar 2014 19:40:33 +0000
Received: by mail-we0-f170.google.com with SMTP id w61so6327877wes.15
	for <xen-devel@lists.xenproject.org>;
	Tue, 18 Mar 2014 12:40:31 -0700 (PDT)
In-Reply-To: <1395160052.11824.7.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Keir Fraser <keir@xen.org>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Shane Wang <shane.wang@intel.com>, Joseph Cihula <joseph.cihula@intel.com>, tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, Gang Wei <gang.wei@intel.com>, Xiantao Zhang <xiantao.zhang@intel.com>
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 03/18/2014 04:27 PM, Ian Campbell wrote:
> On Tue, 2014-03-11 at 15:49 +0000, Julien Grall wrote:
>> +struct arch_hvm_iommu
>> +{
>> +    u64 pgd_maddr;                 /* io page directory machine address */
>> +    int agaw;     /* adjusted guest address width, 0 is level 2 30-bit */
>> +    u64 iommu_bitmap;              /* bitmap of iommu(s) that the domain uses */
> 
> Blank line here for clarity?

Sure.

>> +    /* amd iommu support */
>> +    int paging_mode;
>> +    struct page_info *root_table;
>> +    struct guest_iommu *g_iommu;
>> +
> 
> I don't think the following are amd specific, in their original home
> they were up with pgd_maddr and co any way. If they are to stay here
> perhaps a new /* heading */ comment would help?

I don't remember why I changed the order. I will go back to original
order in the next version.

Regards,


-- 
Julien Grall