Re: [RFC PATCH v1 05/10] xen/arm: move gic definitions to seperate file

[Julien Grall <julien.grall@linaro.org>]

Hello Vijay,

Thanks for the patch.

On 03/19/2014 02:17 PM, vijay.kilari@gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> 
> Move gic v2 register definitions to seperate file

separate

> so that gic.h will hold only common definitions
> and helps to define gic v3 definitions.
> 
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> ---
> diff --git a/xen/include/asm-arm/gic_v2_defs.h b/xen/include/asm-arm/gic_v2_defs.h
> new file mode 100644
> index 0000000..2366685
> --- /dev/null
> +++ b/xen/include/asm-arm/gic_v2_defs.h
> @@ -0,0 +1,136 @@
> +/*
> + * ARM Generic Interrupt Controller support
> + *
> + * Tim Deegan <tim@xen.org>
> + * Copyright (c) 2011 Citrix Systems.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +

Please add guard for this header.

Regards,

-- 
Julien Grall