From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC PATCH v1 10/10] xen/arm: GICv3 device tree
	parsing
Date: Thu, 20 Mar 2014 16:08:28 +0000
Message-ID: <532B127C.3030201@linaro.org>
References: <1395238631-2024-1-git-send-email-vijay.kilari@gmail.com>
	<1395238631-2024-11-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1395238631-2024-11-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com
Cc: Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hello Vijay,

Thanks for the patch. I think the name of this patch is wrong. You are
not parsing the device tree but creating the node for DOM0.

On 03/19/2014 02:17 PM, vijay.kilari@gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> 
> GICv3 supports system register access to GIC cpu interface.
> So no need to read device tree for cpu interface.
> GICv3 adds Re-distributor region and redistributor stride
> which are parsed.

If I understand correctly, DOM0 kernel must support GICv3, right? What
about booting DOM0 with only GICv2 support, e.g. because the kernel is
only using less than 8 CPUs?

[..]

> +    if (hw_type == GIC_VERSION_V3)
> +    {
> +        res = dt_property_read_u32(gic, "redistributor-stride", &rd_stride);
> +        if ( !res )
> +            rd_stride = 0;
> +    }

Actually I would prefer if you introduce an callback to create these new
property.

Regards,

-- 
Julien Grall