From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC PATCH v1 03/10] xen/arm: move vgic data to
	vgic driver
Date: Thu, 20 Mar 2014 17:56:54 +0000
Message-ID: <532B2BE6.6020206@linaro.org>
References: <1395238631-2024-1-git-send-email-vijay.kilari@gmail.com>
	<1395238631-2024-4-git-send-email-vijay.kilari@gmail.com>
	<alpine.DEB.2.02.1403201711200.8273@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1403201711200.8273@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian.Campbell@citrix.com, vijay.kilari@gmail.com, Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, xen-devel@lists.xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 03/20/2014 05:14 PM, Stefano Stabellini wrote:
> On Wed, 19 Mar 2014, vijay.kilari@gmail.com wrote:
>> @@ -142,7 +133,7 @@ struct arch_domain
>>          spinlock_t lock;
>>          int ctlr;
>>          int nr_lines; /* Number of SPIs */
>> -        struct vgic_irq_rank *shared_irqs;
>> +        void *shared_irqs;
> 
> I would prefer to avoid void* fields. Either we introduce a
> vgic_irq_rank union that can be v2 or v3, or we could have a single
> opaque void* pointer that each vgic implementation can use for whatever
> they like. I think that the union is probably better because it would
> let us avoid quite a few casts in the code.
> 

Most of the cast can be removed without this trick :).

IHMO, void * might better to avoid expanding the domain/VCPU structure.
We are already close to the 1 page size.

Regards,

-- 
Julien Grall