From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 2/5] arch, arm: add consistency checks to REMOVE p2m changes Date: Fri, 21 Mar 2014 14:11:31 +0000 Message-ID: <532C4893.1010603@linaro.org> References: <1394914286-29713-1-git-send-email-avanzini.arianna@gmail.com> <1394914286-29713-3-git-send-email-avanzini.arianna@gmail.com> <1395398657.27358.27.camel@kazak.uk.xensource.com> <532C27B3.4050802@citrix.com> <1395402840.27358.66.camel@kazak.uk.xensource.com> <532C2BD1.7040800@linaro.org> <1395405162.19839.25.camel@kazak.uk.xensource.com> <532C347A.4020701@linaro.org> <1395410954.19839.95.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1395410954.19839.95.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, dario.faggioli@citrix.com, tim@xen.org, xen-devel@lists.xen.org, etrudeau@broadcom.com, JBeulich@suse.com, Arianna Avanzini , viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org On 03/21/2014 02:09 PM, Ian Campbell wrote: >> IHMO, memory_unmap should avoid to remove other region than MMIO. Mainly >> because apply_p2m_changes might not remove every reference taken on a page. > > OK, but then the changes to apply_p2m_changes should be less specific to > this case and usable even for e.g. sanity checking the removal of ram > mappings too. That was my point when I answered to arianna few days ago :). -- Julien Grall