From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC PATCH v1 06/10] xen/arm: split gic driver into
 generic and gicv2 driver
Date: Fri, 21 Mar 2014 17:37:29 +0000
Message-ID: <532C78D9.2080705@linaro.org>
References: <1395238631-2024-1-git-send-email-vijay.kilari@gmail.com>
	<1395238631-2024-7-git-send-email-vijay.kilari@gmail.com>
	<532B1114.7030002@linaro.org>
	<1395423133.25521.54.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1395423133.25521.54.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 03/21/2014 05:32 PM, Ian Campbell wrote:
> On Thu, 2014-03-20 at 16:02 +0000, Julien Grall wrote:
>> Hello Vijay,
>>
>> Thanks for the patch.
>>
>> On 03/19/2014 02:17 PM, vijay.kilari@gmail.com wrote:
>>> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>>>
>>> Existing GIC driver has both generic code and hw specific
>>> code. Segregate GIC low level driver into gic-v2.c and
>>> keep generic code in existing gic.c file
>>>
>>> GIC v2 driver registers required functions
>>> to generic GIC driver. This helps to plug in next version
>>> of GIC drivers like GIC v3.
>>>
>>> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>>> ---
>>
>> [..]
>>
>>> +
>>> +void __init gicv2_init(void)
>>> +{
>>
>> Instead of calling gicv2_init and gicv3_init from generic, it would be
>> better to the device API (see xen/include/asm-arm/device.h). An example
>> of use is my iommu series (see https://patches.linaro.org/26032/
>> iommu_hardware_setup).
> 
> Is that usable for something needed as soon as interrupt controller
> setup?

As soon as the device tree is parsed, the "device API" can be used :).

Regards,

-- 
Julien Grall