Re: [PATCH v5 12/17] xenctx: change is_kernel_text() into kernel_addr().

[Don Slutz <dslutz@verizon.com>]

On 03/21/14 11:02, Ian Campbell wrote:
> On Thu, 2014-03-20 at 15:07 -0400, Don Slutz wrote:
>> A new enum has been added to allow the caller to determine if this
>> kernel address is a text or data address.  This is currenlty not
>> used, but will be in the next patch.
>>
>> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
>> ---
>>   tools/xentrace/xenctx.c | 70 +++++++++++++++++++++++++++++++++++--------------
>>   1 file changed, 51 insertions(+), 19 deletions(-)
>>
>> diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c
>> index f77f17e..c574996 100644
>> --- a/tools/xentrace/xenctx.c
>> +++ b/tools/xentrace/xenctx.c
>> @@ -33,6 +33,15 @@
>>   #define DEFAULT_BYTES_PER_LINE 32
>>   #define DEFAULT_LINES 5
>>   
>> +/* Note: the order of these matter.
>> + * NOT_KERNEL_ADDR must be < both KERNEL_DATA_ADDR and KERNEL_TEXT_ADDR.
>> + * KERNEL_DATA_ADDR must be < KERNEL_TEXT_ADDR. */
>> +typedef enum type_of_addr_ {
>> +    NOT_KERNEL_ADDR,
> AKA a User Address?
>
>

Yes.
    -Don Slutz