From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC PATCH v1 06/10] xen/arm: split gic driver into
 generic and gicv2 driver
Date: Sun, 23 Mar 2014 14:43:05 +0000
Message-ID: <532EF2F9.6000603@linaro.org>
References: <1395238631-2024-1-git-send-email-vijay.kilari@gmail.com>	<1395238631-2024-7-git-send-email-vijay.kilari@gmail.com>	<alpine.DEB.2.02.1403201152060.8273@kaball.uk.xensource.com>
	<CALicx6uZu3CB2WmtE0KZpRPG6yuHodufvbM4gti3uH0BR3gqMA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CALicx6uZu3CB2WmtE0KZpRPG6yuHodufvbM4gti3uH0BR3gqMA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vijay Kilari <vijay.kilari@gmail.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, Vijaya Kumar K <vijaya.kumar@caviumnetworks.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Hello Vijay,

On 22/03/14 09:32, Vijay Kilari wrote:
> On Thu, Mar 20, 2014 at 5:25 PM, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
>> On Wed, 19 Mar 2014, vijay.kilari@gmail.com wrote:
>>> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>>>
>>> Existing GIC driver has both generic code and hw specific
>>> code. Segregate GIC low level driver into gic-v2.c and
>>> keep generic code in existing gic.c file
>>>
>>> GIC v2 driver registers required functions
>>> to generic GIC driver. This helps to plug in next version
>>> of GIC drivers like GIC v3.
>>>
>>> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
>>
>> Am I correct in assuming that this patch is just code movement plus the
>> introduction of struct gic_hw_operations?
>>
> Yes, as a part of code movement, I introduced this structure and
> used this callbacks in generic code

 From what I saw, this patch is not only code movement. You are 
modifying/removing some functions without any explanation (see SGI stuffs).

I would prefer if you modify theses on another patch. So this patch will 
only be code movement.

Regards

-- 
Julien Grall