From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4 3/7] arch,
 arm: let map_mmio_regions() take pfn as parameters
Date: Tue, 25 Mar 2014 12:54:39 +0000
Message-ID: <53317C8F.5040404@linaro.org>
References: <1395712976-19454-1-git-send-email-avanzini.arianna@gmail.com>
	<1395712976-19454-4-git-send-email-avanzini.arianna@gmail.com>
	<alpine.DEB.2.02.1403251220080.20389@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1403251220080.20389@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, Arianna Avanzini <avanzini.arianna@gmail.com>, viktor.kleinik@globallogic.com
List-Id: xen-devel@lists.xenproject.org

Hi Stefano and Arianna,

On 03/25/2014 12:22 PM, Stefano Stabellini wrote:
>> -    return apply_p2m_changes(d, INSERT, start_gaddr, end_gaddr,
>> -                             maddr, MATTR_DEV, p2m_mmio_direct);
>> +    return apply_p2m_changes(d, INSERT,
>> +                             pfn_to_paddr(start_gfn),
>> +                             pfn_to_paddr(end_gfn),
>> +                             pfn_to_paddr(mfn),
>> +                             MATTR_DEV, p2m_mmio_direct);
>>  }
> 
> This doesn't make any sense. Shouldn't you modify apply_p2m_changes to
> take pfns as parameters too?

If so, I think it should be a separate patch. Her change makes sense
with the current interface.

Regards,

-- 
Julien Grall